use buffers for uint32 WASM params #6291
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ripple/wasmi-host-functions #6291 +/- ##
===========================================================
Coverage 80.4% 80.4%
===========================================================
Files 854 854
Lines 67574 67588 +14
Branches 7313 7297 -16
===========================================================
+ Hits 54319 54346 +27
+ Misses 13255 13242 -13
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
| return result; | ||
|
|
||
| return x < 0 ? x : (x >= 5 ? x : 0); | ||
| return sqn >= 5 ? (int32_t)sqn : 0; |
There was a problem hiding this comment.
We make changes to support values which are greater than INT_MAX, so you should return 1 here, not sqn
sqn >= 5 ? 1 : 0;
| if (BEAST_EXPECT(result.has_value())) | ||
| BEAST_EXPECT(result.value() == env.current()->parentCloseTime().time_since_epoch().count()); | ||
| } | ||
|
|
There was a problem hiding this comment.
You should fix the tests, not just delete them
There was a problem hiding this comment.
They are no longer relevant. We no longer have code there to check. There is no longer any such error case in these functions.
| } | ||
|
|
||
| template <class IW> | ||
| Expected<uint64_t, HostFunctionError> |
| auto const seq = getDataUInt32(runtime, params, index); | ||
| if (!seq) | ||
| { | ||
| return hfResult(results, seq.error()); // LCOV_EXCL_LINE |
There was a problem hiding this comment.
removing // LCOV_EXCL_LINE - Did you make some tests that can reach this point ?
There was a problem hiding this comment.
I was planning to but didn't get around to it yesterday. Will do that today.
2 participants
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)