-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: Add Formats and Fields to server_definitions #6321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
godexsoft
wants to merge
57
commits into
XRPLF:develop
Choose a base branch
from
godexsoft:feature/flags-server-definitions
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,169
−503
Open
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
e736965
first stab
mvadari c91afc0
move server_definitions to new file
mvadari 491c6ec
move AccountSet to app
mvadari acac1c9
[WIP] flags
mvadari 97a2912
finish flags
mvadari 945c5fd
clean up
mvadari 7c4d63b
add universal flags
mvadari 34fdea9
split out common fields
mvadari a8b0043
Merge remote-tracking branch 'upstream/develop' into server_definitions2
mvadari cbecdb2
fix flags
mvadari 38a29ab
fix flags
mvadari 034198e
Merge branch 'develop' into server_definitions2
mvadari fa0d5a6
Merge remote-tracking branch 'upstream/develop' into server_definitions2
mvadari 09ec4ef
Merge branch 'develop' into server_definitions2
mvadari 85b015b
Merge branch 'develop' into server_definitions2
mvadari b84a348
Merge branch 'develop' into server_definitions2
mvadari edb04af
add lsf flags
mvadari 7a4d423
Merge branch 'develop' into server_definitions2
mvadari 3e1661b
Merge branch 'develop' into server_definitions2
mvadari b51292b
Merge branch 'develop' into server_definitions2
mvadari e5d6f02
Merge branch 'develop' into server_definitions2
mvadari de9777d
match spec
mvadari cf9b68c
Merge branch 'develop' into server_definitions2
mvadari 7753f93
fix build issue
mvadari 7e7f497
Merge branch 'develop' into server_definitions2
mvadari 571950d
Merge branch 'develop' into server_definitions2
mvadari a2c0fdc
Merge branch 'develop' into server_definitions2
mvadari 1e4596d
Merge branch 'develop' into server_definitions2
mvadari 70ff709
Merge commit '92046785d1fea5f9efe5a770d636792ea6cab78b' into server_d…
mvadari 498d533
Merge branch 'develop' into server_definitions2
mvadari 0d57f57
Merge branch 'develop' into server_definitions2
godexsoft 5a8748a
Add tests for updated server_definitions
godexsoft 1a97d9c
Merge branch 'develop' into feature/flags-server-definitions
godexsoft cb74a25
Trigger ci
godexsoft b7db360
Remove todo and add include
godexsoft 93bb55f
Fix include
godexsoft af8e903
Cleanup
godexsoft 1707ef6
Fix formatting
godexsoft 378aa4e
Merge branch 'develop' into feature/flags-server-definitions
godexsoft ae47880
Merge branch 'develop' into feature/flags-server-definitions
godexsoft a457fb7
Use universal instead of Universal
godexsoft 2c33afc
Remove total size checks to avoid having to update everytime we add n…
godexsoft 458651f
Replace initializer_list with vector where applicable
godexsoft 1617a24
Modernize a bit
godexsoft 11b0d53
Fix simple review comments
godexsoft 4684bb1
Add test for batch mask
godexsoft cd65cb3
Fix batch mask via XMACRO
godexsoft 49ea46d
Merge branch 'develop' into feature/flags-server-definitions
godexsoft 63c2325
Add suggestions from review
godexsoft cedda9d
Merge branch 'feature/flags-server-definitions' of github.com:godexso…
godexsoft 84ff4b6
Merge branch 'develop' into feature/flags-server-definitions
godexsoft d3fe934
Fix suggestion from review
godexsoft 88e9ff9
Merge develop
godexsoft 7c392be
Fix ODR violation and SIOF
godexsoft bdd534a
Merge branch 'develop' into feature/flags-server-definitions
ximinez 655cfd3
Fix review comments
godexsoft 80afdd9
Add note about reflection
godexsoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new changelog entry for "XRP Ledger server version 3.2.0" doesn’t include a release date, while the surrounding entries do. Please either add the release date (if known) or adjust the heading/link text to match the established format used in this file for unreleased/new versions.