-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: grep for failures in CI #6339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2d529a2
22a25cf
3fddd79
82d7645
78f11bc
1294aac
7e804a5
d4bc64b
4d385e9
8760f80
7e53b33
de3a64c
322ac32
967bdc4
4505091
ea61d6d
2bae8ee
c6cfdf1
eceb5fc
6964335
715916e
93d0e12
9028c2e
404451a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5340,20 +5340,20 @@ class Vault_test : public beast::unit_test::suite | |
| env.close(); | ||
|
|
||
| // 2. Mantissa larger than uint64 max | ||
| env.set_parse_failure_expected(true); | ||
| try | ||
| { | ||
| tx[sfAssetsMaximum] = "18446744073709551617e5"; // uint64 max + 1 | ||
| env(tx, THISLINE); | ||
| BEAST_EXPECT(false); | ||
| BEAST_EXPECTS(false, "Expected parse_error for mantissa larger than uint64 max"); | ||
| } | ||
| catch (parse_error const& e) | ||
| { | ||
| using namespace std::string_literals; | ||
| BEAST_EXPECT( | ||
| e.what() == | ||
| "invalidParamsField 'tx_json.AssetsMaximum' has invalid " | ||
| "data."s); | ||
| e.what() == "invalidParamsField 'tx_json.AssetsMaximum' has invalid data."s); | ||
| } | ||
| env.set_parse_failure_expected(false); | ||
|
Comment on lines
+5343
to
+5356
|
||
| } | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These commands assume a bash + GNU userland (
set -o pipefail,tee,grep). On Windows runners (and sometimes macOS depending on shell), the default shell may be PowerShell andgrepmay be unavailable, causing the workflow to fail or skip the intended behavior. Specifyshell: bashexplicitly for these steps and/or add OS-conditional implementations (PowerShell equivalent on Windows).