Skip to content

stdcoroutine-2: Migrate production entry points from Boost.Coroutine to C++20 coroutines #6423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pratikmankawde wants to merge 22 commits into
base: pratik/Swtich-to-std-coroutines
Choose a base branch
from
+2,873 −360

Update processRequest comment to Doxygen format

666cafc
Select commit
Loading
Failed to load commit list.
Draft

stdcoroutine-2: Migrate production entry points from Boost.Coroutine to C++20 coroutines #6423

Update processRequest comment to Doxygen format
666cafc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 28, 2026 in 1s

79.8% (target 75.0%)

View this Pull Request on Codecov

79.8% (target 75.0%)

Details

Codecov Report

❌ Patch coverage is 78.46890% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.8%. Comparing base (65e63eb) to head (666cafc).
⚠️ Report is 3 commits behind head on pratik/Swtich-to-std-coroutines.

Files with missing lines Patch % Lines
include/xrpl/core/CoroTaskRunner.ipp 80.3% 14 Missing ⚠️
src/xrpld/rpc/handlers/RipplePathFind.cpp 0.0% 9 Missing ⚠️
include/xrpl/core/CoroTask.h 93.1% 5 Missing ⚠️
src/xrpld/app/main/GRPCServer.cpp 0.0% 4 Missing ⚠️
include/xrpl/core/JobQueue.h 87.5% 2 Missing ⚠️
include/xrpl/core/JobQueueAwaiter.h 80.0% 2 Missing ⚠️
src/libxrpl/nodestore/backend/MemoryFactory.cpp 33.3% 2 Missing ⚠️
src/libxrpl/nodestore/backend/NuDBFactory.cpp 66.7% 2 Missing ⚠️
src/libxrpl/nodestore/backend/NullFactory.cpp 0.0% 2 Missing ⚠️
src/libxrpl/nodestore/backend/RocksDBFactory.cpp 71.4% 2 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           pratik/Swtich-to-std-coroutines   #6423    +/-   ##
================================================================
  Coverage                             79.8%   79.8%            
================================================================
  Files                                  848     851     +3     
  Lines                                67763   67921   +158     
  Branches                              7578    7555    -23     
================================================================
+ Hits                                 54077   54218   +141     
- Misses                               13686   13703    +17
Files with missing lines Coverage Δ
include/xrpl/nodestore/Backend.h 14.3% <ø> (ø)
src/libxrpl/nodestore/DatabaseRotatingImp.cpp 63.9% <100.0%> (ø)
src/xrpld/app/main/Application.cpp 70.0% <ø> (ø)
src/xrpld/app/main/GRPCServer.h 100.0% <ø> (ø)
src/xrpld/rpc/ServerHandler.h 100.0% <ø> (ø)
src/xrpld/rpc/detail/ServerHandler.cpp 87.6% <100.0%> (-0.2%) ⬇️
src/libxrpl/nodestore/DatabaseNodeImp.cpp 39.5% <50.0%> (+4.6%) ⬆️
include/xrpl/core/JobQueue.h 92.9% <87.5%> (-7.1%) ⬇️
include/xrpl/core/JobQueueAwaiter.h 80.0% <80.0%> (ø)
src/libxrpl/nodestore/backend/MemoryFactory.cpp 67.6% <33.3%> (-0.5%) ⬇️
... and 7 more

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov