stdcoroutine-4: Remove Boost.Coroutine dependency and old Coro API#6429
Draft
pratikmankawde wants to merge 6 commits intopratik/std-coro/migrate-test-codefrom
Draft
stdcoroutine-4: Remove Boost.Coroutine dependency and old Coro API#6429pratikmankawde wants to merge 6 commits intopratik/std-coro/migrate-test-codefrom
pratikmankawde wants to merge 6 commits intopratik/std-coro/migrate-test-codefrom
Conversation
66886c9 to
85c2744
Compare
3760e01 to
e23abb3
Compare
85c2744 to
537322d
Compare
e23abb3 to
07ed0de
Compare
537322d to
3126a1d
Compare
07ed0de to
5a6c8b9
Compare
3126a1d to
f2c02be
Compare
5a6c8b9 to
5545df2
Compare
f2c02be to
e807a3a
Compare
5545df2 to
a0868da
Compare
e807a3a to
e6d78aa
Compare
a0868da to
6181882
Compare
e6d78aa to
5a0e822
Compare
6181882 to
7ae27a0
Compare
This was referenced Feb 26, 2026
Draft
5a0e822 to
9445ed1
Compare
2d4720e to
cf05b8f
Compare
9445ed1 to
deb4613
Compare
cf05b8f to
d50f1f1
Compare
deb4613 to
61a87db
Compare
d50f1f1 to
a26f00a
Compare
61a87db to
3e37424
Compare
a26f00a to
de8f8a5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pratik/std-coro/migrate-test-code #6429 +/- ##
=================================================================
Coverage 79.8% 79.8%
=================================================================
Files 850 850
Lines 67854 67854
Branches 7562 7558 -4
=================================================================
+ Hits 54135 54144 +9
+ Misses 13719 13710 -9
🚀 New features to boost your workflow:
|
3e37424 to
00cf265
Compare
de8f8a5 to
98ba7fc
Compare
00cf265 to
e12ae19
Compare
bb62d9c to
f7a0922
Compare
199ed94 to
70f96cd
Compare
f7a0922 to
01d1b84
Compare
70f96cd to
ed9cf56
Compare
01d1b84 to
c7752fe
Compare
ed9cf56 to
91daa1f
Compare
c7752fe to
f4ed00e
Compare
91daa1f to
ddaa264
Compare
Delete the old Boost.Coroutine-based Coro class and all supporting infrastructure, now that all callers have been migrated to the C++20 CoroTaskRunner API: - Delete include/xrpl/core/Coro.ipp (entire file) - Remove class Coro, Coro_create_t, postCoro() from JobQueue.h - Remove the large comment block explaining old Coro lifecycle - Remove boost::coroutine from cmake COMPONENTS and link targets - Remove Boost::context from cmake find_dependency (was only needed by Boost.Coroutine) - Remove BOOST_COROUTINES_NO_DEPRECATION_WARNING compile definition - Remove boost::coroutine from conanfile.py requirements This completes the Boost.Coroutine → C++20 coroutines migration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
f4ed00e to
5666d64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Delete the old Boost.Coroutine-based
Coroclass,postCoro()API, and the entireCoro.ippimplementation file. RemoveBoost.CoroutineandBoost.Contextfrom all build dependencies (CMake, Conan).Context of Change
This is Milestone 4 (final) of the Boost.Coroutine → C++20 coroutines migration:
pratik/std-coro/add-coroutine-primitives): AddedCoroTask<T>,CoroTaskRunner,JobQueueAwaiter,postCoroTask()pratik/std-coro/migrate-entry-points): Migrated all production entry pointspratik/std-coro/migrate-test-code): Migrated all test codeAfter this change, zero references to
postCoro,JobQueue::Coro,Coro.ipp, orBoost.Coroutineremain in the codebase (only the migration plan doc references them).Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)Before / After
Build dependencies removed:
Boost::coroutinefromcmake/deps/Boost.cmake(COMPONENTS and target_link_libraries)Boost::contextfromcmake/XrplConfig.cmake(was only needed by Boost.Coroutine)BOOST_COROUTINES_NO_DEPRECATION_WARNINGfromcmake/XrplInterface.cmakeboost::coroutinefromconanfile.pyCode removed:
include/xrpl/core/Coro.ipp(122 lines, entire file deleted)class Coro,Coro_create_t,postCoro()fromJobQueue.h(~180 lines including comments)