Phase 5b: Add ledger/peer/tx spans + expand Grafana dashboards#6433
Draft
pratikmankawde wants to merge 1 commit intopratik/otel-phase5-docs-deploymentfrom
Draft
Phase 5b: Add ledger/peer/tx spans + expand Grafana dashboards#6433pratikmankawde wants to merge 1 commit intopratik/otel-phase5-docs-deploymentfrom
pratikmankawde wants to merge 1 commit intopratik/otel-phase5-docs-deploymentfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pratik/otel-phase5-docs-deployment #6433 +/- ##
====================================================================
Coverage ? 79.7%
====================================================================
Files ? 851
Lines ? 67968
Branches ? 7607
====================================================================
Hits ? 54182
Misses ? 13786
Partials ? 0
🚀 New features to boost your workflow:
|
This was referenced Feb 26, 2026
fc1ed3c to
3581839
Compare
2194022 to
261caa2
Compare
3581839 to
56cc5e6
Compare
261caa2 to
4fce0da
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
56cc5e6 to
85f583f
Compare
4fce0da to
e2b2589
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Add 6 new OpenTelemetry spans to instrument ledger building, ledger validation,
ledger storage, transaction application, and peer proposal/validation message
receipt. Expand all Grafana dashboards from 4 to 8 panels each and add 2 new
dashboards (Ledger Operations, Peer Network), bringing the total to 32 panels
across 5 dashboards. Each panel now includes a description explaining what it
shows and how the PromQL query calculates the metric.
Context of Change
Phase 5a (the base branch
pratik/otel-phase5-docs-deployment) deliveredconsensus spans, the observability stack (otel-collector, Jaeger, Prometheus,
Grafana), and integration tests. During review, we identified that the
trace_ledgerconfig category existed with itsXRPL_TRACE_LEDGERmacro buthad zero spans using it, and
trace_peerhad only 1 span (tx.receive).Dashboard panels were limited to 4 per dashboard with no panel descriptions.
This PR fills those gaps:
New spans (6, bringing total from 10 to 16):
ledger.buildtrace_ledgerxrpl.ledger.seqledger.validatetrace_ledgerxrpl.ledger.seq,xrpl.ledger.validationsledger.storetrace_ledgerxrpl.ledger.seqtx.applytrace_transactionsxrpl.ledger.tx_count,xrpl.ledger.tx_failedpeer.proposal.receivetrace_peerxrpl.peer.id,xrpl.peer.proposal.trustedpeer.validation.receivetrace_peerxrpl.peer.id,xrpl.peer.validation.trustedDashboard changes (12 → 32 panels):
Type of Change
API Impact
None. This change only adds internal observability instrumentation (OpenTelemetry
spans) and Docker-based Grafana dashboards. No public API, libxrpl, or peer
protocol changes.
Test Plan
Integration test (
bash docker/telemetry/integration-test.sh) passes 24/24with all 16 span types verified across a 6-node consensus network:
rpc.request,rpc.process,rpc.command.*— 5 traces eachtx.process,tx.receive,tx.apply— 5 traces eachconsensus.proposal.send,consensus.ledger_close,consensus.accept,consensus.validation.send— 5 traces eachledger.build,ledger.validate,ledger.store— 5 traces eachpeer.proposal.receive,peer.validation.receive— 5 traces each