add defensive check for sfData length#6449
Open
mvadari wants to merge 1 commit intoXRPLF:ripple/smart-escrowfrom
Open
add defensive check for sfData length#6449mvadari wants to merge 1 commit intoXRPLF:ripple/smart-escrowfrom
mvadari wants to merge 1 commit intoXRPLF:ripple/smart-escrowfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a defensive guard in EscrowFinish::doApply() to ensure any WASM-produced sfData does not exceed the protocol’s maximum allowed length before writing it into the Escrow ledger entry.
Changes:
- Add a size check for
ledgerDataProvider->getData()againstmaxWasmDataLengthprior tosetFieldVL(sfData, ...). - Return
tecINTERNALon the (expected-unreachable) oversized-data condition.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ripple/smart-escrow #6449 +/- ##
=====================================================
- Coverage 80.5% 80.5% -0.0%
=====================================================
Files 855 855
Lines 67809 67810 +1
Branches 7268 7274 +6
=====================================================
- Hits 54618 54608 -10
- Misses 13191 13202 +11
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Title says it all
Context of Change
Going through AI review of the PR
Type of Change
API Impact
N/A
Test Plan
CI passes