Skip to content

chore: Update ripple/smart escrow - #8138

Open
kuznetsss wants to merge 267 commits into
XRPLF:ripple/smart-escrowfrom
kuznetsss:Update-ripple/smart-escrow
Open

chore: Update ripple/smart escrow#8138
kuznetsss wants to merge 267 commits into
XRPLF:ripple/smart-escrowfrom
kuznetsss:Update-ripple/smart-escrow

Conversation

@kuznetsss

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Merge ripple/se/fees and resolve conflicts. Comment out broken tests.

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@kuznetsss
kuznetsss requested a review from a team as a code owner August 28, 2026 15:08
@kuznetsss
kuznetsss force-pushed the Update-ripple/smart-escrow branch from c3410a6 to b050dbb Compare August 28, 2026 17:00
Comment thread src/libxrpl/protocol/TER.cpp
Comment thread include/xrpl/protocol/TER.h
@mathbunnyru
mathbunnyru removed the request for review from a team September 1, 2026 14:07
@kuznetsss
kuznetsss force-pushed the Update-ripple/smart-escrow branch from 72ab5ae to b050dbb Compare September 1, 2026 16:56
mvadari added a commit that referenced this pull request Sep 1, 2026
ripple/smart-escrow's merge-base with develop was very old, so diffing
it directly against develop pulled in unrelated Hooks sfields that
were removed from develop and clobbered newer develop-only fields
(sfContractResult, sfVaultKind, sfSubscriptionDate, sfRedemptionDate).
#8138 rebases the smart-escrow fields onto a recent
develop, so use that diff instead.
mvadari added a commit that referenced this pull request Sep 1, 2026
ripple/smart-escrow's merge-base with develop was very old, so diffing
it directly against develop pulled in unrelated Hooks sfields that
were removed from develop and clobbered newer develop-only fields
(sfContractResult, sfVaultKind, sfSubscriptionDate, sfRedemptionDate).
#8138 rebases the smart-escrow fields onto a recent
develop, so use that diff instead.
mvadari added a commit that referenced this pull request Sep 1, 2026
Ports temBAD_WASM, temTEMP_DISABLED, tefNO_BYTECODE,
tefBYTECODE_NOT_INCLUDED, tecOUT_OF_GAS, and tecBYTECODE_REJECTED
from #8138.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.