Update What is XRP? graphics#3673
Conversation
mDuo13
left a comment
mDuo13
left a comment
There was a problem hiding this comment.
Looking good, although the colors need some adjustment to work in both light & dark modes.
There was a problem hiding this comment.
The text colors here don't provide enough contrast in light mode. They're fine in dark mode.
One approach to make this work would be to use {% include-svg ... %} instead of treating the file as an image, then add CSS styles to overwrite the fill colors within the inlined SVG; this is the theme-aware diagrams approach (note, those docs are slightly out of date).
|  | ||
|  | ||
|
|
||
| Cryptocurrencies, digital currencies, and digital assets all fall into the same general category. They are: |
There was a problem hiding this comment.
This "they are" lead-in feels weird to me with the icon table following it. Maybe rephrase like this?
| Cryptocurrencies, digital currencies, and digital assets all fall into the same general category. They are: | |
| Cryptocurrencies, digital currencies, and digital assets all fall into the same general category. They have these properties in common: |
| Cryptocurrencies, digital currencies, and digital assets all fall into the same general category. They are: | ||
|
|
||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@tabler/icons-webfont@3.19.0/dist/tabler-icons.min.css"/> | ||
| <style> |
There was a problem hiding this comment.
It might be OK as an exception this time, but let's not make a habit of having inlined stylesheets and HTML; they're a maintenance headache.
Ideally the grid would also be theme-aware and change color schemes to match the light/dark themes.
There was a problem hiding this comment.
Put "ripple credits" in all lowercase to reduce ambiguity with Ripple the company and match the paragraph where this is used.
| Originally, the XRP Ledger was called "Ripple" for the way the technology allowed payments [to ripple through multiple hops and currencies](../concepts/tokens/fungible-tokens/rippling.md). For the native asset built into the ledger, the creators chose the ticker symbol "XRP" from the term "ripple credits" or "ripples" and the X prefix for non-national currencies in the [ISO 4217](https://www.iso.org/iso-4217-currency-codes.html) standard. The company registered itself as "Ripple Labs". The name "XRP" came to be used to refer to the asset in all contexts, to avoid confusion with the similar names for the technology and company, and eventually the company shortened its own name to "Ripple". In May 2018, [the community selected a new "X" symbol](https://twitter.com/xrpsymbol/status/1006925937571713025) to represent XRP to differentiate it from the triskelion logo that had previously been used for both the company and the digital asset. | ||
| Originally, the XRP Ledger was called "Ripple" for the way the technology allowed payments [to ripple through multiple hops and currencies](../concepts/tokens/fungible-tokens/rippling.md). For the native asset built into the ledger, the creators chose the ticker symbol "XRP" from the term "ripple credits" or "ripples" and the X prefix for non-national currencies in the [ISO 4217](https://www.iso.org/iso-4217-currency-codes.html) standard. | ||
|
|
||
|  The company registered itself as "Ripple Labs". The name "XRP" came to be used to refer to the asset in all contexts, to avoid confusion with the similar names for the technology and company, and eventually the company shortened its own name to "Ripple". In May 2018, [the community selected a new "X" symbol](https://twitter.com/xrpsymbol/status/1006925937571713025) to represent XRP to differentiate it from the triskelion logo that had previously been used for both the company and the digital asset. |
There was a problem hiding this comment.
Separate the diagram onto its own line instead of having it start the paragraph. Also, this might be another place where {% inline-svg ... /%} might be appropriate for making the diagram theme-aware.
There was a problem hiding this comment.
Suggest using a standard gold bullion icon to represent gold.
3 participants
As part of issue #3672: