[TA-3925]: API Versioning feature#93
Merged
GuillemGarciaDev merged 22 commits intov0.1.xfrom Jan 24, 2025
Merged
Conversation
florent-uzio
approved these changes
Jan 24, 2025
florent-uzio
left a comment
There was a problem hiding this comment.
LGTM, but isn't there a way to include the V1 response directly into the V2 files instead of duplicating the files?
[TA-3931]: Add NoRippleCheck request
Collaborator
Author
We have chosen to group the queries by their versions, even if it means repeating code, and to set the latest version (in this case v2) as the default. This way, in future versions, we can ensure there is no confusion with requests or responses, as there will be a package for each version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[TA-3925]: API Versioning feature
Description
This PR aims to add support for v1 and v2 rippled api versions.
v2is set as default forxrplqueries.Type of change
Checklist:
Changes
v1sub package forxrpl/queriespackages.