Allow LedgerEntryType values in AccountObjects request for canonical ledger entry names#889
Allow LedgerEntryType values in AccountObjects request for canonical ledger entry names#889
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
…er entry names Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com>
@copilot it should actually be |
…stead of str Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com>
Updated to use |
|
@mvadari This PR is in Draft state. Let us know when it's ready for review. |
|
Closing in favor of #895 |
High Level Overview of Change
Updates
AccountObjects.typefield to accept bothAccountObjectTypeenum andLedgerEntryTypeenum values, supporting canonical ledger entry names added in rippled 2.4.0.Context of Change
rippled 2.4.0 added support for canonical ledger entry names (XRPLF/rippled#5271), but the
AccountObjectsmodel only acceptedAccountObjectTypeenum values, rejecting valid requests usingLedgerEntryType.Type of Change
Did you update CHANGELOG.md?
Test Plan
AccountObjectTypeandLedgerEntryTypeenum values intests/unit/models/requests/test_account_objects.pyOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.