Skip to content

Update pre-commit hooks version to v6.0.0 #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cclauss wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update pre-commit hooks version to v6.0.0 #896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# .pre-commit-config.yaml
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v2.3.0
rev: v6.0.0
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify Python version requirements in the repository

echo "=== Checking Python version requirements in the repository ==="

# Check pyproject.toml for Python version
if [ -f "pyproject.toml" ]; then
  echo -e "\n--- pyproject.toml Python requirements ---"
  grep -i "python" pyproject.toml | head -20
fi

# Check setup.py for Python version
if [ -f "setup.py" ]; then
  echo -e "\n--- setup.py Python requirements ---"
  grep -i "python_requires\|version" setup.py | head -10
fi

# Check setup.cfg for Python version
if [ -f "setup.cfg" ]; then
  echo -e "\n--- setup.cfg Python requirements ---"
  grep -i "python_requires\|version" setup.cfg | head -10
fi

# Check for any .python-version files
echo -e "\n--- Checking for .python-version or similar ---"
fd -t f '\.python-version|\.tool-versions' 2>/dev/null | while read file; do
  echo "File: $file"
  cat "$file"
done

# Check CI configuration files for Python versions
echo -e "\n--- CI/CD Python versions ---"
fd -e yml -e yaml 2>/dev/null | head -20 | while read file; do
  if grep -q -i "python" "$file" 2>/dev/null; then
    echo "File: $file"
    grep -i "python" "$file" | head -5
  fi
done

# Check for any tox.ini
if [ -f "tox.ini" ]; then
  echo -e "\n--- tox.ini ---"
  grep -i "python\|envlist" tox.ini | head -10
fi

Repository: XRPLF/xrpl-py

Length of output: 723

Incompatible Python version: v6.0.0 requires Python >= 3.9, but the project declares support for Python >= 3.8.1.

The update to v6.0.0 requires Python >= 3.9, but the project's pyproject.toml declares requires-python = ">=3.8.1". This update will drop support for Python 3.8.x users. Either upgrade the minimum Python requirement to 3.9 in pyproject.toml and remove the conditional dependency handling for Python 3.8, or stay on an older version of pre-commit-hooks that supports Python 3.8.

🤖 Prompt for AI Agents 
.pre-commit-config.yaml around line 4: the pinned pre-commit-hooks rev "v6.0.0"
requires Python >=3.9 which conflicts with pyproject.toml's requires-python =
">=3.8.1"; either (A) bump pyproject.toml requires-python to ">=3.9" and remove
any code/conditional handling intended to support 3.8, then keep rev v6.0.0, or
(B) roll back the rev to the latest pre-commit-hooks release that supports
Python 3.8 (e.g., a v5.x tag) and keep pyproject.toml unchanged; apply the
chosen change consistently across CI configs and update changelogs/requirements
accordingly.

hooks:
- id: check-yaml
- id: end-of-file-fixer
Expand Down