fix(keypairs): Ed25519 verify_strict for canonical-encoding enforcement (#283)#301
Open
satyakwok wants to merge 2 commits into
Open
fix(keypairs): Ed25519 verify_strict for canonical-encoding enforcement (#283)#301satyakwok wants to merge 2 commits into
satyakwok wants to merge 2 commits into
Conversation
…nt (XRPLF#283) `Ed25519::is_valid_message` used `VerifyingKey::verify`, which the dalek 2.x docs explicitly call permissive — it accepts malleable / non-canonical encodings and torsion-point edge cases that RFC 8032 §8.4 prohibits. Switch to `verify_strict`, which matches rippled's verification semantics and avoids the consensus-divergence class where one client accepts a signature the other rejects (or vice versa).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #283.
Summary
Ed25519::is_valid_messagewas callingVerifyingKey::verify, which the dalek 2.x docs explicitly mark as permissive — it accepts malleable / non-canonical encodings and torsion-point edge cases that RFC 8032 §8.4 forbids.Switch to
verify_strict, which:One-line change inside the existing
if let Ok(value) = public { ... }arm.Smoke gate