fix(#174): compile currency/precision regexes once via lazy_static#323
Open
LeJamon wants to merge 1 commit into
Open
fix(#174): compile currency/precision regexes once via lazy_static#323LeJamon wants to merge 1 commit into
LeJamon wants to merge 1 commit into
Conversation
is_hex_address, is_iso_code, is_iso_hex and _calculate_precision rebuilt their Regex on every call. Cache them in lazy_static statics (matching the existing pattern in binarycodec definitions) to avoid recompiling on the hot path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #174.
is_hex_address,is_iso_code,is_iso_hexand_calculate_precisioncalledRegex::new(..)on every invocation, recompiling the pattern on the hot path.Caches the compiled regexes in
lazy_staticstatics, matching the existing pattern used incore/binarycodec/definitions.Testing
cargo test --libandcargo test --doc(existingis_hex_address/is_iso_code/is_iso_hexcoverage)cargo fmt --check; no_std feature set green