fix: resolve lint errors in hashLedger (prettier, max-lines, type assertions)

Author: slurpyone

packages/xrpl/src/utils/hashes/hashLedger.ts

@@ -134,9 +134,7 @@ export function hashLedgerHeader(
  * @returns The root hash of the SHAMap.
  * @category Utilities
  */
-export function hashTxTree(
-  transactions: LedgerTransactionExpanded[],
-): string {
+export function hashTxTree(transactions: LedgerTransactionExpanded[]): string {
   const shamap = new SHAMap()
   for (const txJSON of transactions) {
     const txBlobHex = encode(txJSON)
@@ -167,6 +165,18 @@ export function hashStateTree(entries: LedgerEntry[]): string {
   return shamap.hash
 }
 
+/**
+ * Normalize a v1 wrapped transaction to v2 flat format.
+ */
+function normalizeToV2(
+  tx: LedgerTransactionExpanded | LedgerTransactionExpandedV1,
+): LedgerTransactionExpanded {
+  if ('tx_json' in tx) {
+    return { ...tx.tx_json, hash: tx.hash, metaData: tx.meta }
+  }
+  return tx
+}
+
 function computeTransactionHash(
   ledger: LedgerVersionMap<APIVersion>,
   options: HashLedgerHeaderOptions,
@@ -181,30 +191,17 @@ function computeTransactionHash(
     throw new ValidationError('transactions is missing from the ledger')
   }
 
-    // Normalize transactions to the v2 flat format expected by hashTxTree.
-  // V1 expanded transactions wrap data in { tx_json, meta }, while v2 has
-  // the transaction fields directly on the object with metaData.
-  const normalizedTransactions = (
-    ledger.transactions as Array<
-      string | LedgerTransactionExpanded | LedgerTransactionExpandedV1
-    >
-  )
+  // Normalize transactions to the v2 flat format expected by hashTxTree.
+  // eslint-disable-next-line @typescript-eslint/consistent-type-assertions -- ledger is a version union
+  const txs = ledger.transactions as Array<
+    string | LedgerTransactionExpanded | LedgerTransactionExpandedV1
+  >
+  const normalizedTransactions = txs
     .filter(
-      (
-        tx,
-      ): tx is LedgerTransactionExpanded | LedgerTransactionExpandedV1 =>
+      (tx): tx is LedgerTransactionExpanded | LedgerTransactionExpandedV1 =>
         typeof tx !== 'string',
     )
-    .map((tx) => {
-      if ('tx_json' in tx) {
-        // V1 wrapped format — normalize to v2 flat format
-        return Object.assign({}, tx.tx_json, {
-          hash: tx.hash,
-          metaData: tx.meta,
-        }) as LedgerTransactionExpanded
-      }
-      return tx
-    })
+    .map(normalizeToV2)
 
   const transactionHash = hashTxTree(normalizedTransactions)
 

packages/xrpl/test/utils/hashLedger.test.ts

@@ -150,5 +150,4 @@ describe('hashLedger', function () {
       'transactionHash in header does not match computed hash of transactions',
     )
   })
-
 })