fix: add MPTCurrency type

[khancode]

High Level Overview of Change

This is an equivalent change for JS referencing - XRPLF/xrpl-py#822

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Tests (You added tests for code that already exists, or your new feature included in this PR)
• Documentation Updates
• Release

Did you update HISTORY.md?

• Yes

[coderabbitai]

Walkthrough

This update introduces a new MPTCurrency interface with a mpt_issuance_id property to the codebase. The Currency type is expanded to include this new interface, in addition to the existing IssuedCurrency and XRP types. The changelog is also updated to document the addition of the MPTCurrency type. Additionally, several test files and utility code were modified to replace the generic Currency type with more specific XRP and IssuedCurrency types, and TypeScript expect-error comments were removed from test assertions. No other changes to exported or public entities are present.

Changes

Files/Paths	Change Summary
packages/xrpl/src/models/common/index.ts	Added MPTCurrency interface; updated Currency type to include MPTCurrency.
packages/xrpl/HISTORY.md	Updated changelog to note the addition of the MPTCurrency type.
packages/xrpl/test/integration/setup.ts	Changed TestAMMPool interface: asset typed as XRP, asset2 as IssuedCurrency; updated imports.
packages/xrpl/test/integration/utils.ts	Updated createAMMPool return type and variables: asset as XRP, asset2 as IssuedCurrency; imports updated.
packages/xrpl/test/integration/transactions/ammCreate.test.ts	Removed TypeScript expect-error comment before accessing asset2.issuer.
packages/xrpl/test/integration/transactions/ammDeposit.test.ts	Removed TypeScript expect-error comment before issuer: asset2.issuer assignment.
packages/xrpl/test/integration/transactions/ammWithdraw.test.ts	Removed TypeScript expect-error comment before issuer property assignment.
packages/xrpl/test/integration/requests/ammInfo.test.ts	Removed TypeScript expect-error comment before accessing asset2.issuer.

Suggested reviewers

• achowdhry-ripple
• pdp2121

Poem

In the fields where code and currency play,
A new type hops in—MPT leads the way!
With mpt_issuance_id shining bright,
The union grows stronger, a wonderful sight.
🐇✨
Changelog updated, the future looks sunny—
More types to collect, like carrots and honey!

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0e14000 and 6bb787a.

📒 Files selected for processing (2)

• packages/xrpl/HISTORY.md (1 hunks)
• packages/xrpl/test/integration/utils.ts (3 hunks)

✅ Files skipped from review due to trivial changes (1)

• packages/xrpl/HISTORY.md

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/xrpl/test/integration/utils.ts

⏰ Context from checks skipped due to timeout of 90000ms (12)

• GitHub Check: snippets (22.x)
• GitHub Check: snippets (20.x)
• GitHub Check: snippets (18.x)
• GitHub Check: browser (18.x)
• GitHub Check: unit (18.x)
• GitHub Check: unit (22.x)
• GitHub Check: unit (20.x)
• GitHub Check: integration (18.x)
• GitHub Check: integration (22.x)
• GitHub Check: integration (20.x)
• GitHub Check: build-and-lint (18.x)
• GitHub Check: Analyze (javascript)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mvadari]

Do the same changes not need to be made to the binary codec as well?

[khancode]

Do the same changes not need to be made to the binary codec as well?

@mvadari I checked and it looks like the changes are already correct. Just needed to add MPTCurrency in xrpl