Minor adjustments to RELEASE.md#3127
Conversation
WalkthroughDocumentation updates to clarify release processes. CONTRIBUTING.md renames the manual release section and adds a reference to automated releases. RELEASE.md expands guidance with clearer branch examples, detailed beta/stable release workflows, and new post-release communication steps. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
RELEASE.md (2)
99-107: Post-release communications duplicated across CONTRIBUTING.md and RELEASE.md.Lines 99–107 in RELEASE.md duplicate the post-release notification steps from CONTRIBUTING.md (lines 276–280). This creates maintenance risk: updates to email templates or Discord messaging in one file may not sync to the other.
Consider consolidating these instructions into a single, shared section that both manual and automated workflows reference, or add callout notes if the workflows intentionally require different communication approaches.
124-126: Minor grammar issue in important note.Line 126 contains a grammatical error: "needs to closed" should be "needs to be closed". Additionally, consider clarifying the timeline for when "this step will be removed"—will it be automatic in a future GitHub update, or is it a planned improvement to the workflow?
- PR created from release branch to main branch needs to closed and reopened for the tests to automatically execute. This won't be needed going forward as this step will be removed. + PR created from release branch to main branch needs to be closed and reopened for the tests to automatically execute. This workaround won't be needed in a future release when the workflow is updated.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CONTRIBUTING.md(2 hunks)RELEASE.md(4 hunks)
🧰 Additional context used
🪛 LanguageTool
RELEASE.md
[style] ~99-~99: Consider using “email”.
Context: ...re notifications to Slack. --- ### 6. Send an email to [xrpl-announce](https://groups.google.c...
(SEND_AN_EMAIL)
🔇 Additional comments (6)
CONTRIBUTING.md (1)
223-223: Clear distinction between manual and automated release workflows.Renaming the section to "Manual Release process + checklist" and adding the cross-reference to RELEASE.md effectively guides contributors to the appropriate release path. This structure is helpful for discoverability.
Also applies to: 282-282
RELEASE.md (5)
13-13: Expanded branch name examples improve clarity.The additional examples, including the numeric alpha tag format (
release-xrpl@5.0.0-alpha.1), provide better guidance for creating properly formatted release branches.
21-21: Clear explanation of npm install purpose.Explicitly stating that
npm iupdatespackage-lock.jsonhelps maintainers understand the step's necessity in the release process.
31-34: Enhanced dist tag examples with descriptions.Adding descriptions for each example (stable, pre-release, release candidate) and introducing the
rcoption provides clearer guidance for release tagging decisions.
35-47: Example tables provide concrete field-by-field guidance.The stable and beta release example tables translate the abstract instructions into concrete examples, which will help maintainers correctly fill in the workflow form fields.
49-51: Clarified dual-pause review workflow.Explicitly mentioning both the security scan review pause and the pre-release approval pause helps reviewers understand they need to verify findings at two distinct checkpoints.
|
This PR is no longer needed once #3131 is merged. |
High Level Overview of Change
Minor adjustments to RELEASE.md. This will soon be revamped with updated release process.
Context of Change
Type of Change
Did you update HISTORY.md?
Test Plan