fix: better error handling in connections

packages/xrpl/HISTORY.md

@@ -4,6 +4,9 @@ Subscribe to [the **xrpl-announce** mailing list](https://groups.google.com/g/xr
 
 ## Unreleased
 
+### Fixed
+* Better error handling in the `Client` for edge case errors
+
 ## 4.6.0 (2026-02-12)
 
 ### Added
@@ -15,7 +18,8 @@ Subscribe to [the **xrpl-announce** mailing list](https://groups.google.com/g/xr
 
 ### Added
 * Support for `Lending Protocol` (XLS-66d).
-* Export signing and binary codec utilities.
+* Export signing and binary co
+* dec utilities.
 
 ### Fixed
 * Update ripple-binary-codec to 2.5.1 to address serialization/deserialization issues in `Issue` serialized type for `MPTIssue`.

packages/xrpl/src/client/connection.ts

@@ -335,6 +335,8 @@ export class Connection extends EventEmitter {
    *
    * @param message - The message received from the server.
    */
+
+  // eslint-disable-next-line max-lines-per-function, complexity -- Message handler needs to work with a lot of data
   private onMessage(message): void {
     this.trace('receive', message)
     let data: Record<string, unknown>
@@ -349,7 +351,7 @@ export class Connection extends EventEmitter {
     }
     if (data.type == null && data.error) {
       // e.g. slowDown
-      this.emit('error', data.error, data.error_message, data)
+      this.emit('error', data.error, data.error_message ?? data.error, data)
       return
     }
     if (data.type) {
@@ -367,6 +369,21 @@ export class Connection extends EventEmitter {
         }
       }
     }
+    if (data.type === 'error' && data.value != null) {
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment -- needed
+      const parsedValue: Record<string, unknown> = JSON.parse(
+        // eslint-disable-next-line @typescript-eslint/consistent-type-assertions -- Should be true
+        data.value as string,
+      )
+      if (parsedValue.id != null) {
+        this.requestManager.reject(
+          // eslint-disable-next-line @typescript-eslint/consistent-type-assertions -- Should be true
+          parsedValue.id as string | number,
+          // eslint-disable-next-line @typescript-eslint/consistent-type-assertions -- Should be true
+          new Error(data.error as string),
+        )
+      }
+    }
   }
 
   /**

packages/xrpl/test/connection.test.ts

@@ -5,6 +5,7 @@ import { assert } from 'chai'
 import { HttpsProxyAgent } from 'https-proxy-agent'
 
 import {
+  AccountInfoRequest,
   Client,
   ConnectionError,
   DisconnectedError,
@@ -1028,4 +1029,23 @@ describe('Connection', function () {
     },
     TIMEOUT,
   )
+
+  it('should handle jsonInvalid errors', async function () {
+    const response = {
+      error: 'jsonInvalid',
+      type: 'error',
+      value: '{"command":"submit","tx_json":"badjson"}',
+    }
+    // doesn't matter what the request is, since we're mocking the response
+    const request: AccountInfoRequest = {
+      command: 'account_info',
+      account: 'rQ3PTWGLCbPz8ZCicV5tCX3xuymojTng5r',
+    }
+    clientContext.mockRippled?.addResponse(request.command, response)
+
+    await clientContext.client.request(request).catch((error) => {
+      assert.strictEqual(error.name, 'Error')
+      assert.strictEqual(error.message, 'jsonInvalid')
+    })
+  }, 4000)
 })

packages/xrpl/test/createMockRippled.ts

@@ -21,6 +21,12 @@ export function createResponse(
       )}`,
     )
   }
+  if (response.type === 'error' && 'value' in response) {
+    const value = JSON.parse(response.value as string)
+    value.id = request.id
+    response.value = JSON.stringify(value)
+    return JSON.stringify(response)
+  }
   return JSON.stringify({ ...response, id: request.id })
 }