fix(types): Add missing fields to request and response types#3217
fix(types): Add missing fields to request and response types#3217mpint wants to merge 6 commits intoXRPLF:mainfrom
Conversation
…countLinesResponse
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
WalkthroughThis PR expands multiple xrpl method request and response interfaces by adding optional fields to support ledger metadata exposure, pagination controls, filtering options, and account-specific queries across trust lines, NFT operations, AMM, and vault functionality. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
This PR adds missing fields to various request and response types to improve type completeness and accuracy.
Changes
ledger_current_indexfieldlimitandmarkerfields for paginationlimitandmarkerfields for paginationaccountfieldledger_hash,ledger_index, andvalidatedfieldsignore_defaultfieldlimitfieldMotivation
These fields are documented in the XRP Ledger API but were missing from the TypeScript type definitions, which could lead to type errors when using these fields in applications.
Testing
Pull Request opened by Augment Code with guidance from the PR author