Skip to content

test fixAMMv1_3 Amendment [DO NOT MERGE]#3347

Open
tequdev wants to merge 2 commits into
XRPLF:mainfrom
tequdev:fixAMMv1_3
Open

test fixAMMv1_3 Amendment [DO NOT MERGE]#3347
tequdev wants to merge 2 commits into
XRPLF:mainfrom
tequdev:fixAMMv1_3

Conversation

@tequdev
Copy link
Copy Markdown
Member

@tequdev tequdev commented May 27, 2026

High Level Overview of Change

If the fixAMMv1_3 Amendment is enabled, there is a possibility that the current AMM integration tests might fail.

so Going to run the CI to check on that.

Context of Change

Type of Change

  • Tests (You added tests for code that already exists, or your new feature included in this PR)

Did you update HISTORY.md?

  • Yes
  • No, this change does not impact library users

Test Plan

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Review Change Stack

Walkthrough

The XRPLD rippled test configuration is updated by adding the fixAMMv1_3 amendment entry to the [features] stanza, enabling this amendment during CI test execution.

Changes

Amendment Configuration Update

Layer / File(s) Summary
Enable fixAMMv1_3 amendment in CI config
.ci-config/xrpld.cfg
The fixAMMv1_3 amendment is added to the [features] stanza in the rippled test configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • kuan121
  • achowdhry-ripple
  • pdp2121

Poem

🐰 A single line hops into the config,
fixAMMv1_3 joins the feature flock,
CI tests now dance with amendment delight,
One small change makes the pool logic right! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete with mostly empty templated sections and lacks substantive context for the fixAMMv1_3 amendment configuration change. Complete the 'Context of Change' section explaining the amendment's purpose and why this config change is needed. Fill in the 'Test Plan' section describing tests run to verify the changes.
Title check ❓ Inconclusive The title mentions 'test fixAMMv1_3 Amendment' which relates to the configuration change, but includes '[DO NOT MERGE]' indicating this is not ready for merging despite being submitted as a PR. Clarify the PR's intent: either remove '[DO NOT MERGE]' if ready for review, or convert to a draft PR. Also consider removing 'test' if this is a configuration update rather than a test addition.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tequdev tequdev marked this pull request as draft May 28, 2026 01:06
@tequdev tequdev marked this pull request as ready for review May 28, 2026 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant