Conversation
sappenin
added
enhancement
sappenin
commented
Feb 18, 2025
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: 1.8 | ||
| - name: Cache mvn dependencies |
Collaborator
Author
There was a problem hiding this comment.
Note that actions/setup-java@v4 now includes automatic maven dependency caching, so this section is removed from all configurations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
=========================================
Coverage 92.02% 92.02%
Complexity 1849 1849
=========================================
Files 383 383
Lines 5128 5128
Branches 436 436
=========================================
Hits 4719 4719
Misses 273 273
Partials 136 136 ☔ View full report in Codecov by Sentry. |
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
Per `actions/setup-java`: “AdoptOpenJDK got moved to Eclipse Temurin and won't be updated anymore. It is highly recommended to migrate workflows from adopt and adopt-openj9, to temurin and semeru respectively, to keep receiving software and security updates.”
Fixes #599
…ions # Conflicts: # .github/workflows/workflow.yml
nkramer44
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #583 and #599 by updating the following:
actions/checkout@v4which remove the need foractions/cache.actions/setup-java@v4temurinas the primary distribution for theactions/setup-javaaction.ubuntu-20.04toubuntu-latestper this.NOTE this announcement that describes how
actions/cachewill gradually fail through 2/18/2025 to prod project updates.