Skip to content

Full unit test coverage for all classes in Wrappers.java#665

Open
sappenin wants to merge 8 commits intomainfrom
df/663-more-unit-tests-for-wrappers
Open

Full unit test coverage for all classes in Wrappers.java#665
sappenin wants to merge 8 commits intomainfrom
df/663-more-unit-tests-for-wrappers

Conversation

@sappenin
Copy link
Collaborator

No description provided.

* Add equals/hashcode to XrpCurrencyAmount, MpTokenIssuanceId
* Fix equals/hashcode in CredentialType, CredentialUri, NfTokenId, NfTokenUri
* Add unit test coverage to Wrapper.java

Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
@sappenin sappenin self-assigned this Jan 27, 2026
Signed-off-by: David Fuelling <sappenin@gmail.com>
Base automatically changed from df/592-fix-immutables-warnings to main February 5, 2026 22:44
Signed-off-by: David Fuelling <sappenin@gmail.com>

# Conflicts:
#	xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/AssetScaleTest.java
#	xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/MarkerTest.java
#	xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/MpTokenIssuanceIdTest.java
#	xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/MpTokenMetadataTest.java
#	xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/MpTokenNumericAmountTest.java
#	xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/XrpCurrencyAmountTest.java
Signed-off-by: David Fuelling <sappenin@gmail.com>
@sappenin sappenin marked this pull request as ready for review February 9, 2026 22:30
@sappenin sappenin requested review from Patel-Raj11 and removed request for nhartner and nkramer44 February 9, 2026 22:30
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.57%. Comparing base (4c1b8e8) to head (b532e08).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #665      +/-   ##
============================================
+ Coverage     92.53%   92.57%   +0.03%     
- Complexity     2103     2105       +2     
============================================
  Files           432      432              
  Lines          5735     5735              
  Branches        510      510              
============================================
+ Hits           5307     5309       +2     
+ Misses          280      279       -1     
+ Partials        148      147       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant