Added account permission delegation by cybele-ripple · Pull Request #689 · XRPLF/xrpl4j

cybele-ripple · 2026-02-05T18:05:22Z

Adds support for account permission delegation (XLS-0075)

# Conflicts: # xrpl4j-core/src/main/resources/definitions.json

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/Permission.java

Patel-Raj11 · 2026-02-18T19:53:50Z

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/DelegateSet.java

+  /**
+   * Set of transaction types that cannot be delegated.
+   */
+  Set<String> NON_DELEGABLE_TRANSACTIONS = Sets.newHashSet(


We should use TransactionType enum so that string value remains consistent.

I'm not seeing this fix implemented. Can we keep comments unresolved until they're pushed (to aid in code review)?

Changes made here: a270901#diff-05713a5290db465ee8a57b96b9af5aff76fb39caac1b520d12e843b59e319919L53

I resolved this because the values were at least using TransactionType enum to get string value. But, yes we should do this - Set<TransactionType> NON_DELEGABLE_TRANSACTIONS

Updated to use Set NON_DELEGABLE_TRANSACTIONS

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/DelegateSet.java

Patel-Raj11 · 2026-02-18T20:06:29Z

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/crypto/signing/SignatureUtils.java

      transactionWithSignature = CredentialDelete.builder().from((CredentialDelete) transaction)
        .transactionSignature(signature)
        .build();
+    } else if (DelegateSet.class.isAssignableFrom(transaction.getClass())) {


nit: Since we are adding tests in SignatureUtilsTest for all transaction types, we should add it for DelegateSet.

I see this comment as resolved, but when I run SignatureUtilsTest.java with coverage, it shows this as still uncovered.

Added coverage for this line and reran tests with coverage to confirm

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/ledger/DelegateObject.java

xrpl4j-integration-tests/src/test/java/org/xrpl/xrpl4j/tests/DelegateSetIT.java

* Introduce `transactionFlags()` in a manner that doesn’t break immutables. * Add unit tests to all transactions to verify functionality. * Note this addition is required for Batch functionality to verify inner transaction flags in a generic manner.

First of three PRs for adding support for Batch transactions (XLS-56) * Update tfInnerBatchTxn to all transactions * Increase coverage of BatchFlags

…r permission object with different string vals

package-lock.json

xrpl4j-core/package-lock.json

xrpl4j-integration-tests/src/test/java/org/xrpl/xrpl4j/tests/DelegateSetIT.java

...-core/src/main/java/org/xrpl/xrpl4j/codec/binary/definitions/DefaultDefinitionsProvider.java

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/codec/binary/types/UInt32Type.java

sappenin · 2026-02-20T18:40:05Z

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/TransactionType.java

+   * change.</p>
+   */
+  @Beta
+  BATCH("Batch"),


Note: This branch was updated via GH to pull-in changes from main. Because Batch is now in main, this enum is a duplicate, and breaks the build. We'll want to remove this one to get the build working.

Removed enum

…lign with enum, removed package-lock, removed beta batch (becuse batch now in main)

…t metaledger changes

… to those changes

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/ledger/LedgerObject.java

…issue, added Delegate to LedgerEntryRequestParams and associated tests

Patel-Raj11

Looks good for beta release.

...-core/src/main/java/org/xrpl/xrpl4j/codec/binary/definitions/DefaultDefinitionsProvider.java

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/DelegateSet.java

xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/json/DelegateSetJsonTest.java

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/DelegateSet.java

sappenin · 2026-02-20T21:28:13Z

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/DelegateSet.java

+  /**
+   * Set of transaction types that cannot be delegated.
+   */
+  Set<String> NON_DELEGABLE_TRANSACTIONS = Sets.newHashSet(


I'm not seeing this fix implemented. Can we keep comments unresolved until they're pushed (to aid in code review)?

xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/ledger/DelegateObjectJsonTest.java

xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/DelegateSetTest.java

sappenin · 2026-02-20T21:43:45Z

xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/DelegateSetTest.java

+  @Test
+  public void testAllNonDelegatableTransactionTypesWithEnum() {
+    // Test all non-delegatable transaction types using TransactionType enum
+    TransactionType[] nonDelegatableTypes = {


Should we instead reuse DelegateSet#NON_DELEGABLE_TRANSACTIONS here?

Overall, I worry too about future transaction added to the library that eventually become untested, either here or in testAllDelegatableTransactionTypes. Maybe we should first take all transactions in the enum, and remove the undelegateble ones? That way, if anyone adds a new TransactionType in the future, it will get included in here automatically.

WDYT?

Test now takes all TransactionType vals
As of now, new delegable transaction types just need to be added to the TransactionType enum. Adding non delegable transactions just involves an additional change to a single file so I think the current implementation is fine.

xrpl4j-integration-tests/src/test/java/org/xrpl/xrpl4j/tests/DelegateIT.java

…rovider, added javadoc

codecov · 2026-02-20T23:58:50Z

Codecov Report

❌ Patch coverage is 98.21429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.99%. Comparing base (1063883) to head (7cc6652).

Files with missing lines	Patch %	Lines
...j/codec/binary/definitions/DefinitionsService.java	33.33%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #689      +/-   ##
============================================
+ Coverage     92.91%   92.99%   +0.07%     
- Complexity     2220     2265      +45     
============================================
  Files           437      443       +6     
  Lines          6025     6135     +110     
  Branches        536      549      +13     
============================================
+ Hits           5598     5705     +107     
- Misses          279      281       +2     
- Partials        148      149       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: David Fuelling <sappenin@gmail.com>

…ar permissions

sappenin · 2026-02-26T19:26:03Z

xrpl4j-bom/pom.xml

    <artifactId>xrpl4j-parent</artifactId>
    <groupId>org.xrpl</groupId>
-    <version>HEAD-SNAPSHOT</version>
+    <version>HEAD-SNAPSOT</version>


Looks like a typo.

cybele-ripple added 2 commits February 5, 2026 09:47

added account permission delegation

474eb81

remove extra files

ba48f46

cybele-ripple requested review from nhartner, nkramer44 and sappenin as code owners February 5, 2026 18:05

cybele-ripple added 3 commits February 6, 2026 09:37

defined explicit permission values, added unit tests, added lookups

7304367

Merge branch 'main' into account-permission-delegation

fc834c7

# Conflicts: # xrpl4j-core/src/main/resources/definitions.json

updated integration tests and field implementation

a9d902b

Patel-Raj11 reviewed Feb 18, 2026

View reviewed changes

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/Permission.java Outdated Show resolved Hide resolved

Patel-Raj11 reviewed Feb 18, 2026

View reviewed changes

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/DelegateSet.java Show resolved Hide resolved

Patel-Raj11 reviewed Feb 18, 2026

View reviewed changes

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/ledger/DelegateObject.java Show resolved Hide resolved

Patel-Raj11 reviewed Feb 18, 2026

View reviewed changes

xrpl4j-integration-tests/src/test/java/org/xrpl/xrpl4j/tests/DelegateSetIT.java Show resolved Hide resolved

Patel-Raj11 requested changes Feb 18, 2026

View reviewed changes

sappenin removed request for nhartner and nkramer44 February 18, 2026 21:57

sappenin and others added 7 commits February 18, 2026 15:32

Batch PR1: Add tfInnerBatchTxn to all transactions

ab0045c

First of three PRs for adding support for Batch transactions (XLS-56) * Update tfInnerBatchTxn to all transactions * Increase coverage of BatchFlags

added account permission delegation

be9d4f7

new enum for granularpermission, added transactiontype enum, check fo…

d9ff2f1

…r permission object with different string vals

removed incomplete file

9868950

resolve merge conflicts

408efff

added integration tests related to Delegate

af2fc8f

Patel-Raj11 reviewed Feb 20, 2026

View reviewed changes

package-lock.json Outdated Show resolved Hide resolved

Patel-Raj11 reviewed Feb 20, 2026

View reviewed changes

xrpl4j-core/package-lock.json Outdated Show resolved Hide resolved

Patel-Raj11 reviewed Feb 20, 2026

View reviewed changes

xrpl4j-integration-tests/src/test/java/org/xrpl/xrpl4j/tests/DelegateSetIT.java Outdated Show resolved Hide resolved

Patel-Raj11 reviewed Feb 20, 2026

View reviewed changes

...-core/src/main/java/org/xrpl/xrpl4j/codec/binary/definitions/DefaultDefinitionsProvider.java Outdated Show resolved Hide resolved

Patel-Raj11 reviewed Feb 20, 2026

View reviewed changes

...-core/src/main/java/org/xrpl/xrpl4j/codec/binary/definitions/DefaultDefinitionsProvider.java Outdated Show resolved Hide resolved

Patel-Raj11 reviewed Feb 20, 2026

View reviewed changes

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/codec/binary/types/UInt32Type.java Outdated Show resolved Hide resolved

Patel-Raj11 requested changes Feb 20, 2026

View reviewed changes

Merge branch 'main' into account-permission-delegation

d5ce28f

sappenin reviewed Feb 20, 2026

View reviewed changes

combined delegateset and delegate it, updated GranularPermission to a…

be26ff3

…lign with enum, removed package-lock, removed beta batch (becuse batch now in main)

cybele-ripple requested a review from Patel-Raj11 February 20, 2026 18:54

cybele-ripple added 2 commits February 20, 2026 12:01

added metadelegateobject, updated metaledger, updated tests to reflec…

a270901

…t metaledger changes

removed changes made to UInt32Type and removed unit test that related…

4844bc4

… to those changes

Patel-Raj11 reviewed Feb 20, 2026

View reviewed changes

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/ledger/LedgerObject.java Outdated Show resolved Hide resolved

cybele-ripple added 2 commits February 20, 2026 12:48

added DelegateLedgerEntryParams and related tests, fixed line length …

38c887c

…issue, added Delegate to LedgerEntryRequestParams and associated tests

added for loop to create permissionValues from GranularPermission

26c6a98

Patel-Raj11 reviewed Feb 20, 2026

View reviewed changes

sappenin requested changes Feb 20, 2026

View reviewed changes

cybele-ripple added 4 commits February 20, 2026 14:17

changed from null to return optional

f3ca876

ensure line <=120 chars

bd1b597

remove extra blank lines, added test coverage for DefaultDefinitionsP…

ea3dcea

…rovider, added javadoc

checkstyle fix

e32e21d

Patel-Raj11 and others added 4 commits February 20, 2026 19:12

set version to 6.1.0-rc.1-SNAPSHOT

30cf686

Set version back to HEAD-SNAPSHOT

35c6694

Signed-off-by: David Fuelling <sappenin@gmail.com>

renamed permissions to accountpermissions, streamlined listing granul…

198668f

…ar permissions

Merge branch 'main' into account-permission-delegation

9f3b13a

sappenin reviewed Feb 26, 2026

View reviewed changes

cybele-ripple added 4 commits February 26, 2026 13:31

added test coverage

bfdaafc

fixed snapshot typo

5bd0628

added coverage for SignatureUtils.java

2b357cc

used TransactionType for non_delegable_transactions

7cc6652

cybele-ripple requested review from Patel-Raj11 and sappenin February 26, 2026 22:23

Conversation

cybele-ripple commented Feb 5, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Patel-Raj11 Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sappenin Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Patel-Raj11 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Patel-Raj11 Feb 20, 2026 •

edited

Loading

sappenin Feb 20, 2026 •

edited

Loading

codecov bot commented Feb 20, 2026 •

edited

Loading