Refactor: Alphabetically sort transaction type conditionals in Signat…Refactor: Alphabetically sort transaction type handling in SignatureUtils (#701)#707
Open
LukasDEDD wants to merge 2 commits intoXRPLF:mainfrom
Conversation
…ureUtils This refactor alphabetically orders the long if/else chains in both addSignatureToTransaction and addMultiSignaturesToTransaction to improve readability, maintainability, and reduce merge conflicts when adding new transaction types. No functional behavior is changed.
LukasDEDD
requested review from
nhartner,
nkramer44 and
sappenin
as code owners
sappenin
requested changes
Feb 24, 2026
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/crypto/signing/SignatureUtils.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/crypto/signing/SignatureUtils.java
Show resolved
Hide resolved
Author
|
I hope everything is OK now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the refactor requested in issue #701 by alphabetically
sorting the long
if/else ifchains in:addSignatureToTransaction(...)addMultiSignaturesToTransaction(...)Both methods contain large conditional blocks that map runtime transaction
types to their corresponding builders. Alphabetical ordering improves:
What was changed
else ifbranches alphabetically by transaction class nameWhy this change is safe
Additional notes
This is a pure refactor with no functional impact. It aligns the codebase with
the maintainers' request for improved maintainability and consistency.