Updates for Batch v1_1#808
Merged
Merged
Conversation
Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
Contributor
|
Nice! |
Signed-off-by: David Fuelling <sappenin@gmail.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
Patel-Raj11
reviewed
Jul 13, 2026
Patel-Raj11
reviewed
Jul 13, 2026
Patel-Raj11
reviewed
Jul 13, 2026
Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
Patel-Raj11
previously approved these changes
Jul 17, 2026
Signed-off-by: David Fuelling <sappenin@gmail.com>
sappenin
marked this pull request as ready for review
July 20, 2026 21:51
cybele-ripple
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Augments the
Batchfunctionality to conform to the changes in the specification proposed in PR XRPLF/XRPL-Standards#563 (and slated to be implemented inxrpldvia XRPLF/rippled#6446).Marking this as draft until a valid
xrpldcontainer is published. Until then, the ITs in this build won't pass.--
Batch V1.1 Implementation (XLS-0056)
Implements the V1.1 spec changes for the Batch transaction type (XLS-0056).
Key changes
BatchSigners auto-sort (V1.1 wire format requirement)
BatchSigners cap and extra-signers rule (V1.1 spec changes)
Signing path (SignatureUtils, AbstractSignatureService, TransactionSigner)
Docs and validation clarifications
Integration tests