Skip to content

GitHub Action CI: Add Go source file format check#6090

Open
KobeArthurScofield wants to merge 6 commits intoXTLS:mainfrom
KobeArthurScofield:gofmt-dryrun
Open

GitHub Action CI: Add Go source file format check#6090
KobeArthurScofield wants to merge 6 commits intoXTLS:mainfrom
KobeArthurScofield:gofmt-dryrun

Conversation

@KobeArthurScofield
Copy link
Copy Markdown
Contributor

#6057 (comment)

全局检查一遍,有问题直接列出文件路径以及具体更改并且错误码触发 Actions 错误,不写回仓库

@Fangliding
Copy link
Copy Markdown
Member

1 还得先全core format一遍 不然自己炸自己
2 道义上应该用 go run ./infra/vformat/main.go (需要下载gofumpt)

@KobeArthurScofield
Copy link
Copy Markdown
Contributor Author

还得先全core format一遍 不然自己炸自己

暂时来说为了测试效果有意为之,后面再看什么时机 format 一次(现在格式化问题确实一堆)

道义上应该用 go run ./infra/vformat/main.go (需要下载gofumpt)

安排上了,不过 main/commands/all/tls/ech.go 似乎有点格式化问题,会无尽提示有问题

@KobeArthurScofield
Copy link
Copy Markdown
Contributor Author

给 vformat 增加了格式检查功能(默认还是格式化并写出),暂时禁用 gci 避免在部分文件出现的格式化打架问题

gofumpt 有点小问题,但是不影响整体用到的功能(格式化和检查都没什么大问题),也没想到有什么解决方法。

没什么要改的话就这样吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants