Skip to content

Conversation

Alirexaa
Copy link
Collaborator

@Alirexaa Alirexaa commented Aug 5, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Please reference the issue this PR will close: #2006
Special notes for your reviewer:

I changed healthchecks_elasticsearch_ci.yml and healthchecks_kafka_ci.yml to make ci green.

Elasticsearch tests failed because of mariotoffia/FluentDocker#312 and actions/runner-images#9692.
So I made a temporary fix based on mariotoffia/FluentDocker#312 (comment).

Kafka ci failed because of deprecated images. I did update to new ones.

Does this PR introduce a user-facing change?:

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@Alirexaa
Copy link
Collaborator Author

@adamsitnik, please take a look.

@Alirexaa Alirexaa requested a review from eerhardt November 20, 2024 23:38
@Alirexaa
Copy link
Collaborator Author

@eerhardt, Could you review this PR?
Adding CPM will make it easier for us to target .NET 9.

There are a lot of NU1903 warnings in the project when using VS 17.12.
you can find an example at #2317

@eerhardt
Copy link
Collaborator

I just had 2 comments. Everything else looks good to me.

@adamsitnik @unaizorrilla - any concerns with this?

@Alirexaa
Copy link
Collaborator Author

I just had 2 comments. Everything else looks good to me.

@adamsitnik @unaizorrilla - any concerns with this?

Thanks for the review.

@Alirexaa Alirexaa requested a review from eerhardt November 25, 2024 05:57
Copy link
Collaborator

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@eerhardt
Copy link
Collaborator

Adding CPM will make it easier for us to target .NET 9.

@Alirexaa @unaizorrilla @sungam3r @adamsitnik - do you know of a timeline when HealthChecks 9.0 would be released?

Copy link
Collaborator

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution @Alirexaa !

@adamsitnik adamsitnik merged commit 140ba72 into master Dec 3, 2024
60 checks passed
@adamsitnik adamsitnik deleted the alirexaa/cpm branch December 3, 2024 16:01
@adamsitnik adamsitnik added this to the 9.0 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment