Migrate HealthChecks.SqlServer tests to Testcontainers #2348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
github_actions
71 tasks
adamsitnik
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Overall it looks great, but it would be nice if we could simplify the yml file and reuse the pattern in other PRs (so introducing changes in the future like updating to .NET 10 requires even fewer changes).
Thank you @Alirexaa !
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| services: |
There was a problem hiding this comment.
Seeing this change made me realize that we now may be able to do some yaml refactoring and reuse the https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/master/.github/workflows/reusable_ci_workflow.yml file.
The jobs part for this file could be just:
jobs:
build:
uses: ./.github/workflows/reusable_ci_workflow.yml
with:
PROJECT_PATH: ./src/HealthChecks.SqlServer/HealthChecks.SqlServer.csproj
TEST_PROJECT_PATH: ./test/HealthChecks.SqlServer.Tests/HealthChecks.SqlServer.Tests.csproj
CODECOV_FLAGS: SqlServer(I took the example from
)
adamsitnik
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Contributes to #2335
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Please make sure you've completed the relevant tasks for this PR, out of the following list: