Skip to content

Conversation

monofunc
Copy link
Contributor

What this PR does / why we need it: Add Testcontainers fixture to HealthChecks.ClickHouse tests

Which issue(s) this PR fixes: Contributes to #2335

Please reference the issue this PR will close:

Special notes for your reviewer:

Does this PR introduce a user-facing change?: No

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@monofunc monofunc force-pushed the feature/migrate-clickhouse-tests-to-testcontainers branch from eea52e6 to 2916c80 Compare August 14, 2025 17:32
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.91%. Comparing base (72d9abf) to head (2916c80).
⚠️ Report is 37 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2412      +/-   ##
==========================================
+ Coverage   66.88%   69.91%   +3.02%     
==========================================
  Files         268       43     -225     
  Lines        8730      904    -7826     
  Branches      631       78     -553     
==========================================
- Hits         5839      632    -5207     
+ Misses       2723      243    -2480     
+ Partials      168       29     -139     
Flag Coverage Δ
ApplicationStatus ?
ArangoDb 28.30% <ø> (ø)
Aws.S3 ?
Aws.SecretsManager ?
Aws.Sns ?
Aws.Sqs ?
Aws.SystemsManager ?
Azure.IoTHub ?
AzureApplicationInsights ?
AzureBlobStorage ?
AzureDigitalTwin ?
AzureEventHubs ?
AzureFileStorage ?
AzureKeyVault 22.69% <ø> (-7.80%) ⬇️
AzureQueueStorage ?
AzureSearch ?
AzureServiceBus ?
AzureTableStorage ?
Consul 24.32% <ø> (ø)
CosmosDb 29.45% <ø> (ø)
Dapr ?
DocumentDb ?
DynamoDb ?
Elasticsearch ?
EventStore 65.14% <ø> (ø)
EventStore.gRPC ?
Gcp.CloudFirestore ?
Gremlin ?
Hangfire ?
IbmMQ ?
InfluxDB ?
Kafka ?
Kubernetes ?
Milvus ?
MongoDb ?
MySql ?
Nats 16.40% <ø> (-56.37%) ⬇️
Npgsql ?
OpenIdConnectServer 42.48% <ø> (ø)
Oracle ?
Prometheus.Metrics ?
Publisher.ApplicationInsights ?
Publisher.CloudWatch 20.33% <ø> (ø)
Publisher.Datadog 17.19% <ø> (ø)
Publisher.Prometheus 18.75% <ø> (ø)
Publisher.Seq ?
Qdrant 18.25% <ø> (ø)
RabbitMQ 50.63% <ø> (ø)
RavenDb ?
Redis ?
SendGrid 17.21% <ø> (ø)
SignalR 25.97% <ø> (ø)
SqlServer ?
Sqlite ?
System ?
UI ?
Uris ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@Alirexaa Alirexaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@Alirexaa Alirexaa merged commit d82593a into Xabaril:master Aug 17, 2025
55 of 58 checks passed
@Alirexaa Alirexaa mentioned this pull request Aug 13, 2025
71 tasks
@monofunc monofunc deleted the feature/migrate-clickhouse-tests-to-testcontainers branch August 17, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants