Skip to content

Migrate HealthChecks.ClickHouse to use official ClickHouse client library #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Migrate HealthChecks.ClickHouse to use official ClickHouse client library #2441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<PackageVersion Include="Azure.Storage.Blobs" Version="12.19.1" />
<PackageVersion Include="Azure.Storage.Files.Shares" Version="12.17.1" />
<PackageVersion Include="Azure.Storage.Queues" Version="12.17.1" />
<PackageVersion Include="ClickHouse.Client" Version="7.8.2" />
<PackageVersion Include="ClickHouse.Driver" Version="0.7.20" />
<PackageVersion Include="Confluent.Kafka" Version="2.3.0" />
<PackageVersion Include="coverlet.collector" Version="6.0.0" />
<PackageVersion Include="Dapr.Client" Version="1.12.0" />
Expand Down
2 changes: 1 addition & 1 deletion src/HealthChecks.ClickHouse/ClickHouseHealthCheck.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using ClickHouse.Client.ADO;
using ClickHouse.Driver.ADO;
using Microsoft.Extensions.Diagnostics.HealthChecks;

namespace HealthChecks.ClickHouse;
Expand Down
2 changes: 1 addition & 1 deletion src/HealthChecks.ClickHouse/DependencyInjection/ClickHouseHealthCheckBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using ClickHouse.Client.ADO;
using ClickHouse.Driver.ADO;
using HealthChecks.ClickHouse;
using Microsoft.Extensions.Diagnostics.HealthChecks;

Expand Down
2 changes: 1 addition & 1 deletion src/HealthChecks.ClickHouse/HealthChecks.ClickHouse.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="ClickHouse.Client" />
<PackageReference Include="ClickHouse.Driver" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion src/HealthChecks.ClickHouse/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## ClickHouse Health Check

This health check verifies the ability to communicate with [ClickHouse](https://www.clickhouse.com/). It uses the [ClickHouse.Client](https://www.nuget.org/packages/ClickHouse.Client) library.
This health check verifies the ability to communicate with [ClickHouse](https://www.clickhouse.com/). It uses the official [ClickHouse.Driver](https://www.nuget.org/packages/ClickHouse.Driver) library.

## Recommended approach

Expand Down
2 changes: 1 addition & 1 deletion test/HealthChecks.ClickHouse.Tests/DependencyInjection/RegistrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using ClickHouse.Client.ADO;
using ClickHouse.Driver.ADO;

namespace HealthChecks.ClickHouse.Tests.DependencyInjection;

Expand Down
2 changes: 1 addition & 1 deletion test/HealthChecks.ClickHouse.Tests/Functional/ClickHouseHealthCheckTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
using System.Net;
using ClickHouse.Client.ADO;
using ClickHouse.Driver.ADO;
using Microsoft.Extensions.DependencyInjection.Extensions;
using Microsoft.Extensions.Logging;

Expand Down
4 changes: 2 additions & 2 deletions test/HealthChecks.ClickHouse.Tests/HealthChecks.ClickHouse.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ namespace HealthChecks.ClickHouse
{
public class ClickHouseHealthCheck : Microsoft.Extensions.Diagnostics.HealthChecks.IHealthCheck
{
public ClickHouseHealthCheck(ClickHouse.Client.ADO.ClickHouseConnection connection, string command) { }
public ClickHouseHealthCheck(ClickHouse.Driver.ADO.ClickHouseConnection connection, string command) { }
public System.Threading.Tasks.Task<Microsoft.Extensions.Diagnostics.HealthChecks.HealthCheckResult> CheckHealthAsync(Microsoft.Extensions.Diagnostics.HealthChecks.HealthCheckContext context, System.Threading.CancellationToken cancellationToken = default) { }
}
}
namespace Microsoft.Extensions.DependencyInjection
{
public static class ClickHouseHealthCheckBuilderExtensions
{
public static Microsoft.Extensions.DependencyInjection.IHealthChecksBuilder AddClickHouse(this Microsoft.Extensions.DependencyInjection.IHealthChecksBuilder builder, System.Func<System.IServiceProvider, ClickHouse.Client.ADO.ClickHouseConnection> connectionFactory, string healthQuery = "SELECT 1;", string? name = null, Microsoft.Extensions.Diagnostics.HealthChecks.HealthStatus? failureStatus = default, System.Collections.Generic.IEnumerable<string>? tags = null, System.TimeSpan? timeout = default) { }
public static Microsoft.Extensions.DependencyInjection.IHealthChecksBuilder AddClickHouse(this Microsoft.Extensions.DependencyInjection.IHealthChecksBuilder builder, System.Func<System.IServiceProvider, ClickHouse.Driver.ADO.ClickHouseConnection> connectionFactory, string healthQuery = "SELECT 1;", string? name = null, Microsoft.Extensions.Diagnostics.HealthChecks.HealthStatus? failureStatus = default, System.Collections.Generic.IEnumerable<string>? tags = null, System.TimeSpan? timeout = default) { }
}
}
Loading