Conversation
|
It is currently working fine in my local build. |
Make it easy for projects to depend on libxrpl by adding an `ALIAS` target named `xrpl::libxrpl` for projects to link. The name was chosen because: * The current library target is named `xrpl_core`. There is no other "non-core" library target against which we need to distinguish the "core" library. We only export one library target, and it should just be named after the project to keep things simple and predictable. * Underscores in target or library names are generally discouraged. * Every target exported in CMake should be prefixed with the project name. By adding an `ALIAS` target, existing consumers who use the `xrpl_core` target will not be affected. * In the future, there can be a migration plan to make `xrpl_core` the `ALIAS` target (and `libxrpl` the "real" target, which will affect the filename of the compiled binary), and eventually remove it entirely. Also: * Fix the Conan recipe so that consumers using Conan import a target named `xrpl::libxrpl`. This way, every consumer can use the same instructions. * Document the two easiest methods to depend on libxrpl. Both have been tested. * See #4443.
tequdev
left a comment
tequdev
left a comment
There was a problem hiding this comment.
We should make sure that the workflow is successful after clearing the cache once before marge.
|
Considering rippled sync, I think it is valuable to keep the workflow YML file names consistent with the rippled file names. |
I would agree however @sublimator did some fancy stuff and were also not using hosted runners. So what if we just keep those old files and then disabled the workflow in github so theres not merge conflicts? |
|
Ja, I made some of the files Xahau namespaced so it's easy to use our now
diverged GH runners without fighting conflicts later. Ripple seems to have
some serious resources dedicated to their self hosted runners. It also
makes it easier to see at a glance what is surplus/different to rippled.
That said, I am on phone atm and not sure exactly what is being discussed
|
These seem to be required checks that are no longer in the github workflows ? |
|
Is this ready now? should something else be merged first? |
I think this is needed. we can delete cache from here. |
just deleted and added a nothing commit to force a rebuild |
|
Woooo
|
4 participants
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)