Skip to content

Add GitHub Actions workflow for CHooks testing source#440

Closed
tequdev wants to merge 6 commits intoXahau:devfrom
tequdev:build-test-hook-macos
Closed

Add GitHub Actions workflow for CHooks testing source#440
tequdev wants to merge 6 commits intoXahau:devfrom
tequdev:build-test-hook-macos

Conversation

@tequdev
Copy link
Member

@tequdev tequdev commented Feb 13, 2025

High Level Overview of Change

  • Ensure build_test_hooks.sh works on macOS environments
  • Maintain cross-platform compatibility between Linux and macOS

Note: requires 'ggrep' to be installed via Homebrew on macOS

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

- Ensure build_test_hooks.sh works on macOS environments
- Maintain cross-platform compatibility between Linux and macOS

Note: requires 'ggrep' to be installed via Homebrew on macOS
@tequdev tequdev changed the title Make build_test_hooks.sh compatible with macOS Add GitHub Actions workflow for CHooks testing source [DO NOT MERGE] Feb 25, 2025
- Create new GitHub Actions workflow for testing C hooks
- Refactor build_test_hooks.sh script
- Enhance script to work across different environments
@tequdev tequdev changed the title Add GitHub Actions workflow for CHooks testing source [DO NOT MERGE] Add GitHub Actions workflow for CHooks testing source Feb 26, 2025
@tequdev
Copy link
Member Author

tequdev commented Mar 12, 2025

@RichardAH
Copy link
Contributor

can this be closed? was it already dealt with in that merged pr? @tequdev

@tequdev tequdev closed this Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants