Skip to content

feat(jshooks): add cmake custom command to compile test hooks#560

Closed
sublimator wants to merge 3 commits intojshooksfrom
nd-add-cmake-custom-command-to-compile-test-hooks-2025-07-31
Closed

feat(jshooks): add cmake custom command to compile test hooks#560
sublimator wants to merge 3 commits intojshooksfrom
nd-add-cmake-custom-command-to-compile-test-hooks-2025-07-31

Conversation

@sublimator
Copy link
Collaborator

@sublimator sublimator commented Jul 31, 2025

  • replace shell script with more peformant python script
  • master header includes build/jshooks/generated/test.hook.$hash.inc files
    • looks for // @hook comment in hooks and places next to include
    • less annoying when running git diff without explicit ignore
    • first looks in usual location
  • cmake locates or builds qjsc
  • paves way to use TypeScript and/or hooks in separate files

TODO:

  • SH Release builder unable to use python 3 (Probably just wait for Make release build use conan deps where possible and hbb 4.0.1 #516 which uses python3)

    -- Using LLVMConfig.cmake in: /usr/lib64/llvm13/lib/cmake/llvm/
    -- ACL not found, continuing without ACL support
    CMake Error at /hbb/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
      Could NOT find Python3 (missing: Python3_EXECUTABLE Interpreter)
    
          Reason given by package: 
              Interpreter: Wrong major version for the interpreter "/usr/bin/python"
    

- replace shell script with more peformant python script
- master header includes build/jshooks/generated/test.hook.$hash.inc files
  - looks for // @hook comment in hooks and places next to include
  - less annoying when running git diff without explicit ignore
  - first looks in usual location
- cmake locates or builds qjsc
  - searches for qjsc in previous place or honours QJSC_BINARY file
  - if not found builds from https://github.com/RichardAH/quickjslite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant