Conversation
tequdev
force-pushed
the
hook-api-unittest
branch
from
24622b9 to
c732609
Compare
12 tasks
Add api() method to HookContext that lazily initializes a single HookAPI instance, eliminating repeated instantiation overhead. Simplify call sites to use hookCtx.api().xxx() directly.
sublimator
pushed a commit
that referenced
this pull request
Feb 16, 2026
3 tasks
RichardAH
pushed a commit
that referenced
this pull request
Feb 16, 2026
* Hook API Refactor2: Amendment Guards (#621) * Hook API Refactor3: Consolidate the Hook API definitions from Enum.h and ApplyHook.h into a single file. (#622) * Hook API Refactoring / Unit Testing (#581) * Hook API Refactor2: Amendment Guards (#621) * Hook API Refactor3: Consolidate the Hook API definitions from Enum.h and ApplyHook.h into a single file. (#622) * Hook API Refactoring / Unit Testing (#581) * fix: update clang-format to v18 and fix include ordering - Update verify-generated-headers CI to use clang-format 18 (matching clang-format.yml) instead of stale v10 which can't parse .clang-format - Add .mise.toml for local clang-format 18 tooling - Fix include ordering in cherry-picked files per clang-format 18 * chore: update levelization results for HookAPI changes New loop: xrpl.hook <-> xrpld.app due to HookAPI.h including Transaction.h from xrpld.app. --------- Co-authored-by: tequ <git@tequ.dev>
RichardAH
pushed a commit
that referenced
this pull request
Feb 18, 2026
* Hook API Refactor2: Amendment Guards (#621) * Hook API Refactor3: Consolidate the Hook API definitions from Enum.h and ApplyHook.h into a single file. (#622) * Hook API Refactoring / Unit Testing (#581) * fix `Xahau Ledger` to `Xahau Network` (#651) * Add GitHub Actions workflow for Guard Checker Build (#658) * fix `Xahau Ledger` to `Xahau Network` (#651) * Add GitHub Actions workflow for Guard Checker Build (#658) * fix: update guard checker build path for directory restructure * fix: update stale ripple include paths in hook headers * fix(test): avoid deleted PublicKey default ctor in HookAPI test * chore(levelization): update ordering after hook/protocol dependency change --------- Co-authored-by: tequ <git@tequ.dev>
4 tasks
sublimator
added a commit
that referenced
this pull request
Feb 19, 2026
* Hook API Refactor2: Amendment Guards (#621) * Hook API Refactor3: Consolidate the Hook API definitions from Enum.h and ApplyHook.h into a single file. (#622) * Hook API Refactoring / Unit Testing (#581) * Hook API Refactor2: Amendment Guards (#621) * Hook API Refactor3: Consolidate the Hook API definitions from Enum.h and ApplyHook.h into a single file. (#622) * Hook API Refactoring / Unit Testing (#581) * fix: update clang-format to v18 and fix include ordering - Update verify-generated-headers CI to use clang-format 18 (matching clang-format.yml) instead of stale v10 which can't parse .clang-format - Add .mise.toml for local clang-format 18 tooling - Fix include ordering in cherry-picked files per clang-format 18 * chore: update levelization results for HookAPI changes New loop: xrpl.hook <-> xrpld.app due to HookAPI.h including Transaction.h from xrpld.app. --------- Co-authored-by: tequ <git@tequ.dev>
sublimator
added a commit
that referenced
this pull request
Feb 19, 2026
* Hook API Refactor2: Amendment Guards (#621) * Hook API Refactor3: Consolidate the Hook API definitions from Enum.h and ApplyHook.h into a single file. (#622) * Hook API Refactoring / Unit Testing (#581) * fix `Xahau Ledger` to `Xahau Network` (#651) * Add GitHub Actions workflow for Guard Checker Build (#658) * fix `Xahau Ledger` to `Xahau Network` (#651) * Add GitHub Actions workflow for Guard Checker Build (#658) * fix: update guard checker build path for directory restructure * fix: update stale ripple include paths in hook headers * fix(test): avoid deleted PublicKey default ctor in HookAPI test * chore(levelization): update ordering after hook/protocol dependency change --------- Co-authored-by: tequ <git@tequ.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)