Open
Conversation
RichardAH
commented
Feb 5, 2026
Comment on lines
-1186
to
+1187
| return ( | ||
| // A Signer object always contains these fields and no | ||
| // others. | ||
| obj.isFieldPresent(sfAccount) && | ||
| obj.isFieldPresent(sfSigningPubKey) && | ||
| obj.isFieldPresent(sfTxnSignature) && obj.getCount() == 3); | ||
| if (obj.getCount() != 4 || !obj.isFieldPresent(sfAccount)) | ||
| return false; |
Contributor
Author
There was a problem hiding this comment.
if (!obj.isFieldPresent(sfAccount))
return false;
// leaf signer
if (obj.isFieldPresent(sfSigningPubKey) &&
obj.isFieldPresent(sfTxnSignature) &&
!obj.isFieldPresent(sfSigners))
return obj.getCount() == 3;
// nested signer
if (!obj.isFieldPresent(sfSigningPubKey) &&
!obj.isFieldPresent(sfTxnSignature) &&
obj.isFieldPresent(sfSigners))
return obj.getCount == 2;
RichardAH
commented
Feb 5, 2026
| if (lastAccountID == accountID) | ||
| return Unexpected("Duplicate Signers not allowed."); | ||
| checkSignersArray = [&](STArray const& signersArray, | ||
| AccountID const& parentAccountID, |
Contributor
Author
There was a problem hiding this comment.
unused parentAccuontID
|
First, thank you for doing this. |
Collaborator
Good question, wonder if there should be some kind of leaf specified limit ? |
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NestedMultiSign Amendment
Overview
This amendment introduces nested multi-signature validation, allowing signer lists to delegate signing authority to other accounts that themselves have signer lists. This enables hierarchical organizational structures where, for example, a company account can require signatures from department accounts, which in turn require signatures from authorized individuals.
Key Features
Hierarchical Signing (up to 4 levels deep)
Company → Departments → Teams → IndividualsCycle Detection & Quorum Relaxation
effectiveQuorum == 0(all signers cyclic) correctly fail withtefBAD_QUORUMTransaction Structure
Nested signers are represented by including an
sfSignersarray instead ofsfSigningPubKey/sfTxnSignature:{ "Signers": [{ "Signer": { "Account": "DepartmentA", "Signers": [{ "Signer": { "Account": "Employee1", "SigningPubKey": "...", "TxnSignature": "..." } }] } }] }Validation Rules
SigningPubKeyandTxnSignatureError Codes
tefBAD_SIGNATUREtefBAD_QUORUMtefNOT_MULTI_SIGNINGtefMASTER_DISABLEDtefINTERNALBackward Compatibility
When
featureNestedMultiSignis disabled, nested signer arrays are rejected withtemMALFORMED, preserving existing behavior.