fix: multiple correctness and reliability improvements across NetSM#2
Open
XavierJiezou with Copilot wants to merge 5 commits into
Open
fix: multiple correctness and reliability improvements across NetSM#2XavierJiezou with Copilot wants to merge 5 commits into
XavierJiezou with Copilot wants to merge 5 commits into
Conversation
- core.py: rename __format__ -> _format_speed to avoid Python dunder conflict - core.py: convert speed from @Property to regular method, enabling interval param - core.py: guard addrs with AF_INET fallback to prevent KeyError on non-IPv4 NICs - core.py: intersect NIC sets between snapshots in speed() to handle interface changes - cli.py: pass NetSM instance into generate_table to avoid redundant instantiation - cli.py: eliminate double generate_table call in non-incessant mode (saves 1 sec) - cli.py: use speed.get(nic) and addrs[nic].get('address') to prevent KeyError - tests: update to use speed() and _format_speed - pyproject.toml: fix python_functions = test_* and remove missing integration dir - CI: bump actions/checkout, setup-python, cache to v4; replace deprecated set-output - codecov.yml: install local code instead of stale PyPI release; bump codecov action v4 Agent-Logs-Url: https://github.com/XavierJiezou/NetSM/sessions/19ba3440-ec77-4eda-ac05-176fc20d0550 Co-authored-by: XavierJiezou <43515350+XavierJiezou@users.noreply.github.com>
Agent-Logs-Url: https://github.com/XavierJiezou/NetSM/sessions/19ba3440-ec77-4eda-ac05-176fc20d0550 Co-authored-by: XavierJiezou <43515350+XavierJiezou@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
XavierJiezou
April 30, 2026 17:45
View session
…` in poetry source config Agent-Logs-Url: https://github.com/XavierJiezou/NetSM/sessions/b825d4de-3690-4d24-b82f-9cd4a6138cb3 Co-authored-by: XavierJiezou <43515350+XavierJiezou@users.noreply.github.com>
Agent-Logs-Url: https://github.com/XavierJiezou/NetSM/sessions/bf83e326-0085-420a-9a3d-eb0544ad809f Co-authored-by: XavierJiezou <43515350+XavierJiezou@users.noreply.github.com>
…, regenerate lock file Agent-Logs-Url: https://github.com/XavierJiezou/NetSM/sessions/9cb7725d-3aa1-4c1c-bedd-88762fbec722 Co-authored-by: XavierJiezou <43515350+XavierJiezou@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[tool.poetry.dev-dependencies]→[tool.poetry.group.dev.dependencies]poetry lock)poetry.lockwithpoetry lockpoetry installsucceeds