Skip to content

README.md #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

README.md #22

wants to merge 15 commits into from

Conversation

emanuelcaaju
Copy link
Collaborator

No description provided.

Copy link
Contributor

@codecakes codecakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. I commented to make changes

Copy link
Contributor

@codecakes codecakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some changes pending

@codecakes codecakes linked an issue Nov 6, 2022 that may be closed by this pull request
@codecakes codecakes added documentation Improvements or additions to documentation good first issue Good for newcomers labels Nov 6, 2022
Copy link
Contributor

@codecakes codecakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything Looks good before git commit: 64999a2
However, Note in your PR that this PR is connected to an issue you raised this pr against.
Don't mix other changes into this PR.
This keeps tracking and context of each work separate. keep separate concerns in their individual PRs. Advantages are:

  • keep separate concerns
  • cleaner, smaller PRs.
  • Easy to argue about.

Raise another PR and include the other changes in that PR.
How to do that easily? Do this line by line
Do this first:

git reset --soft 64999a2b069f4a5934a714c1e0d0fa91f6d5c43c

git switch -c <NAME_OF_YOUR_NEW_BRANCH>

git add .

git commit -m "<YOUR COMMIT MESSAGE>"

git push 

What about undoing the changes on this branch?
You need to do this:

git checkout Design_Tokens

git reset --hard 64999a2b069f4a5934a714c1e0d0fa91f6d5c43c

git status  # THIS tells you if you need to git add any files and make another commit.

git rebase develop

This was referenced Nov 16, 2022
@codecakes codecakes added invalid This doesn't seem right wontfix This will not be worked on labels Nov 16, 2022
@codecakes
Copy link
Contributor

cleaner PRs here that need to be reviewed and merged in following order:
PR #34
PR #36

@codecakes codecakes closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers invalid This doesn't seem right wontfix This will not be worked on
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update README for figma token integration with github
2 participants