fix(sponsor-panel): fake email shim for private GitHub users - #1197
Merged
Conversation
… HTMX error display Users with private GitHub emails were rejected when requesting a Thoth token. Now generates login@fake-address.invalid instead. Also changed renderError to return HTTP 200 so HTMX actually swaps error messages into the target elements (HTMX drops non-2xx responses by default). Assisted-by: Claude Opus 4.6 via Claude Code Signed-off-by: Xe Iaso <me@xeiaso.net>
Assisted-by: Claude Opus 4.6 via Claude Code Signed-off-by: Xe Iaso <me@xeiaso.net>
|
The latest Buf updates on your PR. Results from workflow Buf / protobuf (pull_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
login@fake-address.invalidfor GitHub users who don't expose a public email, instead of rejecting them with "Email address required"renderErrorto return HTTP 200 so HTMX actually swaps error messages into card target elements (HTMX drops non-2xx responses by default)Test plan