Skip to content

Undone alphabetised ordering and added missing category letters. #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

daniel-hutchinson-xero-public
Copy link
Contributor

Description

Undone the alphabetised ordering on NICategoryLetter as this affects the outputted enum SDK code. The original order has been added, and any missing category letters have been added at the end.

Release Notes

Fixes a potential issue with the outputted enum SDK code. Reverts back to original ordering while also adding missing letters.

Screenshots (if appropriate):

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

github-actions bot commented Apr 9, 2025

PETOSS-724

Copy link

github-actions bot commented Apr 9, 2025

Thanks for raising an issue, a ticket has been created to track your request

Copy link
Contributor

@sangeet-joy-tw sangeet-joy-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangeet-joy-tw sangeet-joy-tw merged commit dbbb58a into XeroAPI:master Apr 10, 2025
1 check passed
@daniel-hutchinson-xero-public daniel-hutchinson-xero-public deleted the undo-ni-category-letter-ordering branch April 18, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants