Handle unexpected responses #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I will update this PR as soon as the other one has been merged. |
Gitii
force-pushed
the
feat/check-response-code
branch
from
d93e666 to
e40a843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Xetera,
While using your library, I encountered a peculiar JSON decoding error. This issue turned out to be caused by a 302 redirect response, where the Amazon server was attempting to reauthenticate the session.
To address this, I added a check to ensure the response code from Amazon is as expected (200) before parsing the JSON body. This allows callers to catch the error and respond accordingly.
Please take a look at it.
Thanks!