Conversation
🦋 Changeset detectedLatest commit: e6b54b6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Hello @XiNiHa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Gemini here, providing a summary for this pull request. This PR, authored by XiNiHa, is a chore update focused on bumping various project dependencies. The primary goal, as indicated by the title, is to introduce support for Relay version 19 by updating relay-runtime, relay-compiler, and their associated types. Alongside the Relay updates, several other development and documentation dependencies have also been upgraded. A new build step is introduced to handle potential import path issues with relay-runtime.
Highlights
- Relay 19 Support: Updates
relay-runtime,relay-compiler, and their type definitions to version 19 across the main package and example project. The main package'speerDependenciesare updated to include support for Relay v19. - General Dependency Bumps: Numerous other dependencies in the root, docs, and example
package.jsonfiles have been updated, including@solidjs/start,solid-js,vinxi,rspress, testing libraries (vitest,happy-dom), build tools (@changesets/cli,oxc-parser,tsdown,vite-plugin-relay-lite), and@types/node. The pnpm package manager version is also updated. - Build Configuration Update: A new
tsdownplugin (rewrite-relay-runtime-imports) is added to rewriterelay-runtimeimports torelay-runtime/index.jsduring the build process, likely to ensure compatibility or correct module resolution.
Changelog
Click here to see the changelog
- .changeset/hot-spies-walk.md
- Adds a new changeset file for a
patchrelease. - Records the change description: "chore: bump dependencies with Relay 19 support".
- Adds a new changeset file for a
- docs/package.json
- Updates
rspressfrom^1.43.10to^1.44.0. - Updates
@rspress/plugin-typedocfrom^1.43.10to^1.44.0. - Updates
@types/nodefrom^22.14.0to^22.15.21.
- Updates
- example/package.json
- Updates
@solidjs/startfrom^1.1.3to^1.1.4. - Updates
relay-runtimefrom"main"to^19.0.0. - Updates
solid-jsfrom^1.9.3to^1.9.7. - Updates
vinxifrom^0.5.3to^0.5.6. - Removes the
engines.nodefield. - Updates
@types/relay-runtimefrom^18.2.5to^19.0.1. - Updates
relay-compilerfrom^18.2.0to^19.0.0.
- Updates
- package.json
- Updates
peerDependencies.relay-runtimeto accept^18.1.0 || ^19. - Updates
@changesets/clifrom^2.28.1to^2.29.4. - Updates
@types/nodefrom^22.14.0to^22.15.21. - Updates
@types/relay-runtimefrom^18.2.5to^19.0.1. - Updates
@types/relay-test-utilsfrom^18.0.0to^19.0.0. - Updates
@vitest/coverage-v8and@vitest/uifrom^3.1.1to^3.1.4. - Updates
happy-domfrom^17.4.4to^17.4.7. - Updates
oxc-parserfrom^0.64.0to^0.72.0. - Updates
pkg-pr-newfrom^0.0.42to^0.0.50. - Updates
relay-compilerfrom^18.2.0to^19.0.0. - Updates
relay-runtimefrom"main"to^19.0.0. - Updates
relay-test-utilsfrom^18.2.0to^19.0.0. - Updates
solid-jsfrom^1.9.4to^1.9.7. - Updates
tsdownfrom^0.8.0to^0.12.2. - Updates
vite-plugin-relay-litefrom^0.10.0to^0.11.0. - Updates
vitestfrom^3.1.1to^3.1.4. - Updates
packageManager(pnpm) from10.3.0to10.11.0.
- Updates
- tsdown.config.ts
- Adds a new
tsdownplugin namedrewrite-relay-runtime-imports. - This plugin modifies non-declaration files (
.d.ts,.d.mts,.d.cts) to replacefrom 'relay-runtime'withfrom 'relay-runtime/index.js'.
- Adds a new
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Deps get a new bump,
Relay nineteen now is here,
Code builds, tests pass green.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Deploying solid-relay-docs with
|
| Latest commit: |
e6b54b6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5291e3aa.solid-relay-docs.pages.dev |
| Branch Preview URL: | https://bump-deps.solid-relay-docs.pages.dev |
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 27.13% 27.13%
=======================================
Files 21 21
Lines 1360 1360
Branches 65 65
=======================================
Hits 369 369
Misses 991 991 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request effectively bumps dependencies to support Relay 19, which is a valuable update. The changes to package.json files, including the peerDependencies adjustment for relay-runtime, are well-handled. The new tsdown plugin also appears to be a necessary adjustment for the build process with the updated dependencies.
I have one medium-severity suggestion regarding the example/package.json and a couple of minor points noted in the summary that fall below the requested comment severity threshold.
It would also be beneficial for future maintainers if the PR description could briefly explain the rationale behind the new rewrite-relay-runtime-imports plugin in tsdown.config.ts.
Summary of Findings
- Removal of
enginesfield in example project: Theenginesfield was removed fromexample/package.json. It's recommended to specify Node.js version compatibility for example projects to guide users. - Missing PR Description Context (Not Commented): The PR description is empty. Adding context for the new
rewrite-relay-runtime-importsplugin intsdown.config.tswould be beneficial for understanding the changes. (Severity: low, not commented due to review settings) - Removal of
@types/deep-equal(Not Commented): The@types/deep-equaldevDependency was removed from the mainpackage.json. This is likely fine if the package is no longer used or types are handled differently, but a quick confirmation would be good. (Severity: low, not commented due to review settings)
Merge Readiness
The pull request is largely in good shape and accomplishes its goal of updating dependencies for Relay 19 support. There is one medium-severity point regarding the engines field in the example project that should be considered. Addressing this would improve the developer experience for users of the example. I am unable to approve pull requests, so please ensure further review and approval from authorized maintainers before merging.
No description provided.