Skip to content

chore: update versions (beta)#31

Merged
XiNiHa merged 1 commit into
mainfrom
changeset-release/main
Jun 8, 2025
Merged

chore: update versions (beta)#31
XiNiHa merged 1 commit into
mainfrom
changeset-release/main

Conversation

@XiNiHa

@XiNiHa XiNiHa commented Jun 8, 2025

Copy link
Copy Markdown
Owner

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

main is currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, run changeset pre exit on main.

⚠️⚠️⚠️⚠️⚠️⚠️

Releases

solid-relay@1.0.0-beta.12

Patch Changes

  • 354ca39: fix!: drop support for async preloaded queries

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 8, 2025

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
solid-relay 0949e4a Visit preview Jun 08 2025, 06:20 AM

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @XiNiHa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! Gemini here, providing a summary of this pull request. This PR was automatically generated by the Changesets action. Its primary purpose is to update the package version and related files in preparation for a new prerelease version (1.0.0-beta.12) of the solid-relay package. This specific prerelease includes a fix that drops support for async preloaded queries, as indicated by the changeset entry.

Highlights

  • Changelog Entry: A new entry has been added to the CHANGELOG.md file for version 1.0.0-beta.12, documenting a patch change: fix!: drop support for async preloaded queries.
  • Changeset Tracking: The changeset ID silver-cases-heal, corresponding to the fix included in this release, has been added to the .changeset/pre.json file to track it as part of the current prerelease sequence.

Changelog

  • .changeset/pre.json
    • Added the changeset ID silver-cases-heal to the list of changes included in the current prerelease.
  • CHANGELOG.md
    • Added a new section for version 1.0.0-beta.12.
    • Included the patch change description: fix!: drop support for async preloaded queries.
  • package.json
    • Updated the version field from 1.0.0-beta.11 to 1.0.0-beta.12.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@XiNiHa XiNiHa merged commit 482b6ab into main Jun 8, 2025
1 of 2 checks passed
@XiNiHa XiNiHa deleted the changeset-release/main branch June 8, 2025 06:18
@pkg-pr-new

pkg-pr-new Bot commented Jun 8, 2025

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/XiNiHa/solid-relay@31

commit: 0949e4a

@codecov

codecov Bot commented Jun 8, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.90%. Comparing base (354ca39) to head (0949e4a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   27.90%   27.90%           
=======================================
  Files          21       21           
  Lines        1405     1405           
  Branches       70       70           
=======================================
  Hits          392      392           
  Misses       1013     1013           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR updates the version of solid-relay to 1.0.0-beta.12. The changes include version updates in package.json, a new entry in CHANGELOG.md, and modifications to .changeset/pre.json. The primary change is dropping support for async preloaded queries, a breaking change indicated by fix!: in the changelog. The version updates and changelog entry appear correct. However, the API documentation for createPreloadedQuery seems to be outdated and needs to be updated to reflect the removal of MaybePromise from the preloadedQuery parameter type before this release PR is merged.

Summary of Findings

  • Outdated API Documentation for Breaking Change: The API documentation for createPreloadedQuery in docs/src/routes/api/functions/createPreloadedQuery.mdx still includes MaybePromise in the type signature for the preloadedQuery parameter. This contradicts the changelog entry fix!: drop support for async preloaded queries and the actual code implementation. This documentation needs to be updated to reflect the breaking change before this version is released.

Merge Readiness

I recommend against merging this PR until the documentation issue is addressed. The API documentation for createPreloadedQuery must be updated to reflect the breaking change (removal of MaybePromise support for the preloadedQuery parameter). Releasing with outdated documentation for a breaking change can negatively impact users. I am not authorized to approve pull requests, but I advise that this documentation update be completed before proceeding with the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant