slightly less core cells #939
Merged
+2
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lisu-lisa
approved these changes
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the logic for tagging cells near an interface in the mesh dynamics code. The main change is to use the absolute value of the signed distance to the interface, instead of a more complex calculation involving the normal direction, to determine if a cell is near the interface.
Cell tagging logic simplification:
InitialCellTagging::UpdateKernel::updateandInitialCellTaggingFromCoarse::UpdateKernel::update(inmesh_local_dynamics.cpp), replaced the calculation that combined signed distance and normal direction with a simpler check using only the absolute value of the signed distance to determine if a cell is within one grid spacing of the interface. [1] [2]