-
Notifications
You must be signed in to change notification settings - Fork 125
Add backward routing for RapidWright. #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kylepham-amd
wants to merge
7
commits into
Xilinx:master
Choose a base branch
from
kylepham-amd:backward-routing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
45570e8
Add backward routing for RapidWright.
kylepham-amd 057d262
Update source and test codes per previous review's comments:
kylepham-amd 4ffc123
Tidy up TestRWRoute
eddieh-xlnx 284d953
Replace Connection.backwardRouting with config.backwardRouting
eddieh-xlnx 90ee525
Cleaner RWRoute.saveRouting()
eddieh-xlnx 0e6fe63
Refactor to maximize reuse
eddieh-xlnx 46e5cb0
Restore assertion
eddieh-xlnx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -173,6 +173,10 @@ private void setBaseCost(RouteNodeGraph routingGraph) { | |
| case NODE_LAGUNA_DATA: // LAG_LAG.UBUMP* super long lines for u-turns at the boundary of the device (US+) | ||
| case NODE_SLL_INPUT: // Versal only | ||
| case NODE_SLL_OUTPUT: // Versal only | ||
| case NODE_GLOBAL_LEAF: | ||
| case NODE_INT_INTERFACE: | ||
| case NODE_DEDICATED: | ||
| case NODE_OPTDELAY: | ||
|
Comment on lines
+176
to
+179
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should be excluding these nodes from the routing graph entirely (they weren't needed during forward routing) |
||
| case INTENT_DEFAULT: // INT.VCC_WIRE | ||
| assert(length == 0); | ||
| break; | ||
|
|
@@ -495,7 +499,7 @@ public float getBaseCost() { | |
| public RouteNode[] getChildren(RouteNodeGraph routingGraph) { | ||
| if (children == null) { | ||
| long start = RuntimeTracker.now(); | ||
| List<Node> allDownHillNodes = getAllDownhillNodes(); | ||
| List<Node> allDownHillNodes = routingGraph.backwardRouting ? getAllUphillNodes() : getAllDownhillNodes(); | ||
| List<RouteNode> childrenList = new ArrayList<>(allDownHillNodes.size()); | ||
| for (Node downhill : allDownHillNodes) { | ||
| if (isExcluded(routingGraph, downhill)) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.