Complete smbus IP removal from top.tcl#55
Closed
merkelmarrow wants to merge 1 commit intoXilinx:devfrom
Closed
Conversation
Commit b23555b deleted the smbus IP source files from linker/resources/base/iprepo/ but there are still references to the IP in top.tcl. Removes 24 references that causes abstract shell PDI build to fail Signed-off-by: Marco Blackwell <mblackwe@amd.com>
Collaborator
|
Hi @merkelmarrow! I have a question regarding the AVED firmware for this image. After you program the abstract shell PDI in OSPI, and check with v80-smi list, could you also check that ami_tool sensors utility tool still works as intended? |
Author
$ ami_tool sensors -d af:00.0
Error: device has no sensor data
ERET: Invalid return code from function call [ami_sensor_discover:858].Is this a pre-existing issue or is this due to removing SMBus from the build script? If so, how are you including the IP in the build so I can rebuild it? |
Collaborator
|
Hmm, this works with the initial design. Can you provide the following command outputs?
That will make me better understand what's going on. |
Author
Of course: |
Collaborator
|
Looks like the firmware wasn't built properly, or it's missing from the design. What image did you use for flashing the OSPI? |
Author
I believe it was The command I ran was something like sudo ami_tool cfgmem_program -d af:00.0 -t primary -p 0 \
-i <local_path>/SLASH/linker/src/install.prj/AVED/hw/amd_v80_gen5x8_25.1/amd_v80_gen5x8_25.1.pdiAt this point I already had AVED programmed via JTAG and ami_tool could find AMC |
Collaborator
|
That looks good. Did you reboot the machine after programming? |
Author
Yes, this was last week at some point. I'll look through the build log to see if I can find anything relevant. |
Author
|
@hpc-aulmamei What was the reasoning behind removing SMBus? Is it a licensing thing? |
Collaborator
|
@merkelmarrow yes, the smbus IP is not available to the public. It can be obtained from here. It should be added to linker/resources/base/iprepo/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit b23555b deleted the smbus IP source files from
linker/resources/base/iprepo/but there are still references to the IP in top.tcl. This causes the abstract shell PDI build to fail.ERROR: [BD::TCL 103-2012] The following IPs are not found in the IP Catalog: xilinx.com:ip:smbus:1.1This PR removes 24 references to the IP in
linker/resources/base/scripts/top.tcl.Testing
v80-smi listshows board operationaltop.tcl.