Ask on package rebuild#67
Merged
hpc-aulmamei merged 2 commits intoXilinx:devfrom Apr 22, 2026
Merged
Conversation
Signed-off-by: Vlad-Gabriel Serbu <Vlad-Gabriel.Serbu@amd.com>
|
I would advocate for an explicit "non-interactive" or "always say yes" option. You never know in what kinds of situations such a script is executed, so only using the |
Signed-off-by: Vlad-Gabriel Serbu <Vlad-Gabriel.Serbu@amd.com>
Author
|
@JOOpdenhoevel Fair enough. Added --noninteractive to the scripts. |
|
LGTM |
Collaborator
|
lgtm. merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package-deb.sh and package-rpm.sh scripts run a full clean build, including the static shell, starting by removing any previous build.
This patch asks the user if they really want to run the rebuild, to prevent accidental removals.
If the script is run non-interactively (stdin is not a terminal), this question is skipped.
This patch also adds early checks for v++ in path (Vivado/Vitis sourced) and for the smbus, so that the build fails early with descriptive errors if the user has not satisfied the prerequisites for build.