Skip to content

AIESW-871: Adding df_bw support(AIESW-6825) #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aktondak merged 1 commit into from
Dec 16, 2025
Merged

AIESW-871: Adding df_bw support(AIESW-6825) #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions archive/npu3/df_bandwidth/df_bw.elf
View file
Open in desktop
Git LFS file not shown
10 changes: 9 additions & 1 deletion archive/npu3/df_bandwidth/profile_df_bandwidth.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,18 @@
"stride": 4,
"value": 3735928559
}
},
{
"name" : "ofm",
"size" : 1073741824,
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size value 1073741824 is a magic number. Consider adding a comment indicating this is 1GB (102410241024 bytes) to improve readability and match the PR description's reference to '1GB transfer'.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

@sandilya-xilinx sandilya-xilinx Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size is 1073741824 because the elf transfers 1GB data thus allocated 1GB buffer

"init" : {
"stride": 4,
"value": 0
}
}
],
"execution" : {
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description mentions reducing iterations to 100, but doesn't explain why this value was chosen or how it relates to the 1GB transfer requirement. Consider adding a comment explaining the relationship between iterations, buffer size, and total data transferred.

Suggested change
"execution" : {
"execution" : {
// _comment: With a buffer size of 1GB (1073741824 bytes) and 100 iterations, the total data transferred is 100GB. The number of iterations was chosen to achieve a total transfer of 100GB for bandwidth profiling.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

@sandilya-xilinx sandilya-xilinx Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we can comment these json files

"iterations": 600,
"iterations": 100,
"iteration" : {
"init" : false
},
Expand Down
3 changes: 0 additions & 3 deletions archive/npu3/df_bandwidth/recipe_df_bandwidth.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@
"arguments" : [
{ "name": "ifm", "argidx": 0 },
{ "name": "ofm", "argidx": 1 }
],
"constants": [
{ "value": 3, "type": "int", "argidx": 0 }
]
}
]
Expand Down
Binary file modified archive/npu3/xrt_smi_npu3.a
View file
Open in desktop
Binary file not shown.