[XRT-SMI] Removing warning prints for a better UI#9529
Merged
maxzhen merged 3 commits intoXilinx:masterfrom Jan 8, 2026
Merged
[XRT-SMI] Removing warning prints for a better UI#9529maxzhen merged 3 commits intoXilinx:masterfrom
maxzhen merged 3 commits intoXilinx:masterfrom
Conversation
Signed-off-by: Akshay Tondak <aktondak@amd.com>
aktondak
requested review from
AShivangi,
chvamshi-xilinx and
rozumx
as code owners
aktondak
changed the title
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
AShivangi
approved these changes
Jan 7, 2026
Signed-off-by: Akshay Tondak <aktondak@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
AShivangi
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This PR removes the Warning print when running firmware logging in watch mode. Empty buffer is a valid state to be in and persistent print in such a scenario lead to a worse user experience as pointed out during testing from a different team.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
None
How problem was solved, alternative solutions (if any) and why they were rejected
Solved via removing the print
Risks (if any) associated the changes in the commit
None
What has been tested and how, request additional testing if necessary
Tested on linux
Documentation impact (if any)
None