Update dkms-edge.cmake to match the latest dir structure#9726
Merged
chvamshi-xilinx merged 1 commit intoXilinx:masterfrom Apr 14, 2026
Merged
Update dkms-edge.cmake to match the latest dir structure#9726chvamshi-xilinx merged 1 commit intoXilinx:masterfrom
chvamshi-xilinx merged 1 commit intoXilinx:masterfrom
Conversation
Signed-off-by: Takasi, Manoj <Manoj.Takasi@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Edge DKMS staging did not install XRT memory headers in the layout the zocl driver expects (xclhal2_mem.h -> xrt/detail/xrt_mem.h, and top-level xrt_mem.h for -I paths that reference it). Flattening those into driver/zocl/include via the same install(FILES) loop broke includes.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Split flat core headers from xrt_mem.h / xrt/detail/xrt_mem.h, with two explicit install() rules targeting ${XRT_DKMS_INSTALL_DIR}/include/
COMPONENT ${XRT_COMPONENT} on all DKMS-related install() rules so edge artifacts align with XRT’s component-based install/packaging.
Risks (if any) associated the changes in the commit
low..these changes only impact on dkms edge flow.
What has been tested and how, request additional testing if necessary
Tested by running vadd application on kria som kv260 using limerick ubuntu 24.04 image
Documentation impact (if any)