EDGEML-13495: Fix Binskim issues in xrt#9758
Closed
yvonyuan wants to merge 1 commit intoXilinx:masterfrom
Closed
Conversation
stsoe
reviewed
Apr 28, 2026
Signed-off-by: Yvonne Yang <Yvonne.Yang@amd.com> Revert /OPT:REF back for non-debug builds Signed-off-by: Yvonne Yang <Yvonne.Yang@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
Author
Make sense to me. Moved /OPT:REF back to non-Debug only. I will re-run the Binskim check and if the issue is still there, we might consider treat Debug BA6005 as a BinSkim exception |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
Author
|
Closed this PR as after removing xclbinutil from the artifacts for SWV npu driver, issue BA2007 and BA6002 goes away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
https://amd.atlassian.net/browse/EDGEML-13495 and https://amd.atlassian.net/browse/EDGEML-13496
How problem was solved, alternative solutions (if any) and why they were rejected
Fixed Binskim BA6002: eliminate duplicate strings.
Fixed Binskim BA2007: build at warning level 3